Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2801023004: chromeos: Fix chrome --mus startup crashes on device (Closed)

Created:
3 years, 8 months ago by James Cook
Modified:
3 years, 8 months ago
Reviewers:
reveman, Daniel Erat
CC:
chromium-reviews, davemoore+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Fix chrome --mus startup crashes on device Skip things mushrome doesn't have yet: * Cursor manager * DeviceDataManager Also fix some dbus service initialization. After this CL we boot to the login screen. You can't log in yet because input events are still broken. BUG=709097 TEST=manual, chrome --mash and --mus start on desktop and on device Review-Url: https://codereview.chromium.org/2801023004 Cr-Commit-Position: refs/heads/master@{#462694} Committed: https://chromium.googlesource.com/chromium/src/+/1af4615f37b6cd225efc2500c58ef4a8058cc945

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -11 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 3 chunks +18 lines, -7 lines 0 comments Download
M components/exo/wm_helper_ash.cc View 4 chunks +16 lines, -4 lines 0 comments Download
M components/exo/wm_helper_mus.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
James Cook
derat, PTAL at c/b/chromeos reveman, PTAL at components/exo Thanks.
3 years, 8 months ago (2017-04-06 21:46:20 UTC) #2
reveman
lgtm
3 years, 8 months ago (2017-04-06 21:59:30 UTC) #5
Daniel Erat
lgtm
3 years, 8 months ago (2017-04-06 22:02:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801023004/20001
3 years, 8 months ago (2017-04-06 22:51:32 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 00:01:04 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1af4615f37b6cd225efc2500c58e...

Powered by Google App Engine
This is Rietveld 408576698