Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/indexeddb

Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/indexeddb

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED
with DCHECK_op, CHECK_op, and NOTREACHED respectively in
third_party/WebKit/Source/modules/indexeddb

BUG=707641
Review-Url: https://codereview.chromium.org/2801893008
Cr-Commit-Position: refs/heads/master@{#463162}
Committed: https://chromium.googlesource.com/chromium/src/+/5136172049cbea062e1dcf86fa41fceef13183c3

[Hwanseung Lee, 2017-04-09 05:38:16]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-09 05:38:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hwanseung Lee, 2017-04-09 05:38:27]

Description was changed from

==========
Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/indexeddb

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED
with DCHECK_op, CHECK_op, and NOTREACHED respectively in
third_party/WebKit/Source/modules/indexeddb

BUG=707641
==========

to

==========
Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/indexeddb

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED
with DCHECK_op, CHECK_op, and NOTREACHED respectively in
third_party/WebKit/Source/modules/indexeddb

BUG=707641
==========

[Hwanseung Lee, 2017-04-09 05:38:27]

hs1217.lee@samsung.com changed reviewers:
+ dgrogan@chromium.org, tkent@chromium.org

[commit-bot: I haz the power, 2017-04-09 08:46:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-09 08:46:06]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Hwanseung Lee, 2017-04-09 08:47:13]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-09 08:47:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-09 10:44:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-09 10:44:07]

Dry run: This issue passed the CQ dry run.

[Hwanseung Lee, 2017-04-09 11:10:15]

PTAL, thank you.

[haraken, 2017-04-09 13:01:04]

LGTM

[dgrogan, 2017-04-09 14:50:59]

lgtm

[Hwanseung Lee, 2017-04-09 14:58:46]

The CQ bit was checked by hs1217.lee@samsung.com

[commit-bot: I haz the power, 2017-04-09 14:59:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-09 22:04:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-09 22:04:34]

Failed to apply patch for
third_party/WebKit/Source/modules/indexeddb/IDBAny.cpp:
While running git apply --index -3 -p1;
  error: patch failed: third_party/WebKit/Source/modules/indexeddb/IDBAny.cpp:42
  Falling back to three-way merge...
  Applied patch to 'third_party/WebKit/Source/modules/indexeddb/IDBAny.cpp' with
conflicts.
  U third_party/WebKit/Source/modules/indexeddb/IDBAny.cpp

Patch:       third_party/WebKit/Source/modules/indexeddb/IDBAny.cpp
Index: third_party/WebKit/Source/modules/indexeddb/IDBAny.cpp
diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBAny.cpp
b/third_party/WebKit/Source/modules/indexeddb/IDBAny.cpp
index
32b3711a201c4148633ee31f3661b97c81297179..c8166e6a887aba108791e69617cca1b8c9ea6153
100644
--- a/third_party/WebKit/Source/modules/indexeddb/IDBAny.cpp
+++ b/third_party/WebKit/Source/modules/indexeddb/IDBAny.cpp
@@ -42,7 +42,7 @@ IDBAny* IDBAny::createNull() {
 }
 
 IDBAny::IDBAny(Type type) : m_type(type) {
-  ASSERT(type == UndefinedType || type == NullType);
+  DCHECK(type == UndefinedType || type == NullType);
 }
 
 IDBAny::~IDBAny() {}
@@ -53,55 +53,55 @@ void IDBAny::contextWillBeDestroyed() {
 }
 
 DOMStringList* IDBAny::domStringList() const {
-  ASSERT(m_type == DOMStringListType);
+  DCHECK_EQ(m_type, DOMStringListType);
   return m_domStringList.get();
 }
 
 IDBCursor* IDBAny::idbCursor() const {
-  ASSERT(m_type == IDBCursorType);
+  DCHECK_EQ(m_type, IDBCursorType);
   SECURITY_DCHECK(m_idbCursor->isKeyCursor());
   return m_idbCursor.get();
 }
 
 IDBCursorWithValue* IDBAny::idbCursorWithValue() const {
-  ASSERT(m_type == IDBCursorWithValueType);
+  DCHECK_EQ(m_type, IDBCursorWithValueType);
   SECURITY_DCHECK(m_idbCursor->isCursorWithValue());
   return toIDBCursorWithValue(m_idbCursor.get());
 }
 
 IDBDatabase* IDBAny::idbDatabase() const {
-  ASSERT(m_type == IDBDatabaseType);
+  DCHECK_EQ(m_type, IDBDatabaseType);
   return m_idbDatabase.get();
 }
 
 IDBIndex* IDBAny::idbIndex() const {
-  ASSERT(m_type == IDBIndexType);
+  DCHECK_EQ(m_type, IDBIndexType);
   return m_idbIndex.get();
 }
 
 IDBObjectStore* IDBAny::idbObjectStore() const {
-  ASSERT(m_type == IDBObjectStoreType);
+  DCHECK_EQ(m_type, IDBObjectStoreType);
   return m_idbObjectStore.get();
 }
 
 const IDBKey* IDBAny::key() const {
   // If type is IDBValueType then instead use value()->primaryKey().
-  ASSERT(m_type == KeyType);
+  DCHECK_EQ(m_type, KeyType);
   return m_idbKey.get();
 }
 
 IDBValue* IDBAny::value() const {
-  ASSERT(m_type == IDBValueType);
+  DCHECK_EQ(m_type, IDBValueType);
   return m_idbValue.get();
 }
 
 const Vector<RefPtr<IDBValue>>* IDBAny::values() const {
-  ASSERT(m_type == IDBValueArrayType);
+  DCHECK_EQ(m_type, IDBValueArrayType);
   return &m_idbValues;
 }
 
 int64_t IDBAny::integer() const {
-  ASSERT(m_type == IntegerType);
+  DCHECK_EQ(m_type, IntegerType);
   return m_integer;
 }

[Hwanseung Lee, 2017-04-09 23:03:58]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-09 23:04:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 00:29:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 00:29:48]

Dry run: This issue passed the CQ dry run.

[Hwanseung Lee, 2017-04-10 01:02:33]

The CQ bit was checked by hs1217.lee@samsung.com

[Hwanseung Lee, 2017-04-10 01:02:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, dgrogan@chromium.org
Link to the patchset: https://codereview.chromium.org/2801893008/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2017-04-10 01:02:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 01:07:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491786153998070,
"parent_rev": "c8a0f6b4c5ba15333aaf5aabc1a7c74330a523e9", "commit_rev":
"5136172049cbea062e1dcf86fa41fceef13183c3"}

[commit-bot: I haz the power, 2017-04-10 01:08:30]

Description was changed from

==========
Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/indexeddb

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED
with DCHECK_op, CHECK_op, and NOTREACHED respectively in
third_party/WebKit/Source/modules/indexeddb

BUG=707641
==========

to

==========
Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/indexeddb

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED
with DCHECK_op, CHECK_op, and NOTREACHED respectively in
third_party/WebKit/Source/modules/indexeddb

BUG=707641

Review-Url: https://codereview.chromium.org/2801893008
Cr-Commit-Position: refs/heads/master@{#463162}
Committed:
https://chromium.googlesource.com/chromium/src/+/5136172049cbea062e1dcf86fa41...
==========

[commit-bot: I haz the power, 2017-04-10 01:08:31]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5136172049cbea062e1dcf86fa41...