third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp - Issue 2801893008: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/indexeddb

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp

Issue 2801893008: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/indexeddb (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp

diff --git a/third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp b/third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp

index 21b372edb2c73c99425973d2189254807deab2c9..b66a2dbbaa386d625ac2515573c0ab4a61e14d8e 100644

--- a/third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp

+++ b/third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp

@@ -371,7 +371,7 @@ static std::unique_ptr<KeyPath> KeyPathFromIDBKeyPath(

break;

}

default:

- ASSERT_NOT_REACHED();

+ NOTREACHED();

}

return key_path;

@@ -941,7 +941,7 @@ class ClearObjectStore final

DummyExceptionStateForTesting exception_state;

idb_object_store->clear(GetScriptState(), exception_state);

- ASSERT(!exception_state.HadException());

+ DCHECK(!exception_state.HadException());

if (exception_state.HadException()) {

ExceptionCode ec = exception_state.Code();

request_callback_->sendFailure(Response::Error(

« no previous file with comments | « third_party/WebKit/Source/modules/indexeddb/IndexedDBClient.cpp ('k') | no next file » | no next file with comments »