Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2801873004: [Android WebAPK] Fix regression by https://codereview.chromium.org/2725813004/ (Closed)

Created:
3 years, 8 months ago by pkotwicz
Modified:
3 years, 8 months ago
Reviewers:
dominickn, Xi Han
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org, F
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android WebAPK] Fix regression by https://codereview.chromium.org/2725813004/ https://codereview.chromium.org/2725813004/ caused WebappDataStorage#updateTimeOfLastCheckForUpdatedWebManifest() to be called each time that the WebAPK is launched effectively disabling WebAPK updates. BUG=709226 Review-Url: https://codereview.chromium.org/2801873004 Cr-Commit-Position: refs/heads/master@{#464854} Committed: https://chromium.googlesource.com/chromium/src/+/b4c7f73c1d4ee45836f07d959d7af1e4a12cdcc7

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java View 2 chunks +4 lines, -4 lines 2 comments Download

Messages

Total messages: 17 (7 generated)
pkotwicz
Xi can you please take a look?
3 years, 8 months ago (2017-04-06 21:30:35 UTC) #2
Xi Han
https://codereview.chromium.org/2801873004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java File chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java (right): https://codereview.chromium.org/2801873004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java#newcode145 chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java:145: storage.updateTimeOfLastCheckForUpdatedWebManifest(); Since we already fixed the issue that we ...
3 years, 8 months ago (2017-04-07 13:49:20 UTC) #3
pkotwicz
https://codereview.chromium.org/2801873004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java File chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java (right): https://codereview.chromium.org/2801873004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java#newcode145 chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java:145: storage.updateTimeOfLastCheckForUpdatedWebManifest(); Your suggestion makes sense. However, I would rather ...
3 years, 8 months ago (2017-04-07 14:44:03 UTC) #4
Xi Han
lgtm
3 years, 8 months ago (2017-04-07 14:45:18 UTC) #5
pkotwicz
Dominick for OWNERS
3 years, 8 months ago (2017-04-07 15:38:26 UTC) #7
dominickn
lgtm
3 years, 8 months ago (2017-04-07 22:56:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801873004/1
3 years, 8 months ago (2017-04-10 18:39:43 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/154057)
3 years, 8 months ago (2017-04-10 20:34:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801873004/1
3 years, 8 months ago (2017-04-15 02:13:42 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-15 02:53:09 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b4c7f73c1d4ee45836f07d959d7a...

Powered by Google App Engine
This is Rietveld 408576698