Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java

Issue 2801873004: [Android WebAPK] Fix regression by https://codereview.chromium.org/2725813004/ (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
index 6a2286b96221dccc0ff2b9bc1762c5ddf849a714..4cfcc501a817e296e59f38a7d59fc77fee59332a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
@@ -124,10 +124,6 @@ public class WebApkActivity extends WebappActivity {
protected void onDeferredStartupWithStorage(WebappDataStorage storage) {
super.onDeferredStartupWithStorage(storage);
- // Initialize the time of the last is-update-needed check with the registration time. This
- // prevents checking for updates on the first run.
- storage.updateTimeOfLastCheckForUpdatedWebManifest();
-
mUpdateManager = new WebApkUpdateManager(WebApkActivity.this, storage);
mUpdateManager.updateIfNeeded(getActivityTab(),
(WebApkInfo) mWebappInfo);
@@ -144,6 +140,10 @@ public class WebApkActivity extends WebappActivity {
mWebappInfo.id(), new WebappRegistry.FetchWebappDataStorageCallback() {
@Override
public void onWebappDataStorageRetrieved(WebappDataStorage storage) {
+ // Initialize the time of the last is-update-needed check with the
+ // registration time. This prevents checking for updates on the first run.
+ storage.updateTimeOfLastCheckForUpdatedWebManifest();
Xi Han 2017/04/07 13:49:20 Since we already fixed the issue that we shouldn't
pkotwicz 2017/04/07 14:44:03 Your suggestion makes sense. However, I would rath
+
onDeferredStartupWithStorage(storage);
}
});
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698