Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2801853003: Revert of cros: Fix keyboard navigation focus get lost when system tray set to invisible on oobe (Closed)

Created:
3 years, 8 months ago by foolip
Modified:
3 years, 8 months ago
Reviewers:
xiyuan, Qiang(Joe) Xu
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cros: Fix keyboard navigation focus get lost when system tray set to invisible on oobe (patchset #1 id:1 of https://codereview.chromium.org/2794153002/ ) Reason for revert: AutofillInteractiveTest.AutofillAfterReload became flaky right after this landed. The test involves focus (FocusFirstNameField()) and the change also involves focus, so there is likely a connection. BUG=708861 Original issue's description: > cros: Fix keyboard navigation focus get lost when system tray set to invisible on oobe > > Changes: > (1) add tray->visible() check in WebUILoginView::TakeFocus(). > (2) add else branch to avoid an invisible focus stop. > > BUG=707977 > TEST=test that focus loop works > > Review-Url: https://codereview.chromium.org/2794153002 > Cr-Commit-Position: refs/heads/master@{#461741} > Committed: https://chromium.googlesource.com/chromium/src/+/43c00b6dfca02767efa66d7fb110c7cbf28bc019 TBR=xiyuan@chromium.org,warx@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=707977 Review-Url: https://codereview.chromium.org/2801853003 Cr-Commit-Position: refs/heads/master@{#462355} Committed: https://chromium.googlesource.com/chromium/src/+/53436789712c58d9f7d512e6615b4acf46e52f28

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome/browser/chromeos/login/ui/webui_login_view.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
foolip
Created Revert of cros: Fix keyboard navigation focus get lost when system tray set to ...
3 years, 8 months ago (2017-04-06 03:58:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801853003/1
3 years, 8 months ago (2017-04-06 03:58:18 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 04:29:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/53436789712c58d9f7d512e6615b...

Powered by Google App Engine
This is Rietveld 408576698