Chromium Code Reviews
DescriptionRevert of cros: Fix keyboard navigation focus get lost when system tray set to invisible on oobe (patchset #1 id:1 of https://codereview.chromium.org/2794153002/ )
Reason for revert:
AutofillInteractiveTest.AutofillAfterReload became flaky right after
this landed. The test involves focus (FocusFirstNameField()) and the
change also involves focus, so there is likely a connection.
BUG=708861
Original issue's description:
> cros: Fix keyboard navigation focus get lost when system tray set to invisible on oobe
>
> Changes:
> (1) add tray->visible() check in WebUILoginView::TakeFocus().
> (2) add else branch to avoid an invisible focus stop.
>
> BUG=707977
> TEST=test that focus loop works
>
> Review-Url: https://codereview.chromium.org/2794153002
> Cr-Commit-Position: refs/heads/master@{#461741}
> Committed: https://chromium.googlesource.com/chromium/src/+/43c00b6dfca02767efa66d7fb110c7cbf28bc019
TBR=xiyuan@chromium.org,warx@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=707977
Review-Url: https://codereview.chromium.org/2801853003
Cr-Commit-Position: refs/heads/master@{#462355}
Committed: https://chromium.googlesource.com/chromium/src/+/53436789712c58d9f7d512e6615b4acf46e52f28
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|
|||||||||||||||||||