cros: Fix keyboard navigation focus get lost when system tray set to invisible on oobe

cros: Fix keyboard navigation focus get lost when system tray set to invisible on oobe

Changes:
(1) add tray->visible() check in WebUILoginView::TakeFocus().
(2) add else branch to avoid an invisible focus stop.

BUG=707977
TEST=test that focus loop works

Review-Url: https://codereview.chromium.org/2794153002
Cr-Commit-Position: refs/heads/master@{#461741}
Committed: https://chromium.googlesource.com/chromium/src/+/43c00b6dfca02767efa66d7fb110c7cbf28bc019

[Qiang(Joe) Xu, 2017-04-03 23:14:21]

Description was changed from

==========
cros: Fix keyboard navigation focus get lost when system tray set to invisible
on oobe

BUG=707977
TEST=test that focus loop works
==========

to

==========
cros: Fix keyboard navigation focus get lost when system tray set to invisible
on oobe

Changes:
(1) add tray->visible() check in WebUILoginView::TakeFocus().
(2) add else branch to avoid an invisible focus stop.

BUG=707977
TEST=test that focus loop works
==========

[Qiang(Joe) Xu, 2017-04-03 23:14:22]

warx@chromium.org changed reviewers:
+ xiyuan@chromium.org

[Qiang(Joe) Xu, 2017-04-03 23:14:42]

xiyuan@, PTAL, thanks!

[xiyuan, 2017-04-04 15:36:02]

lgtm

[Qiang(Joe) Xu, 2017-04-04 15:52:43]

The CQ bit was checked by warx@chromium.org

[commit-bot: I haz the power, 2017-04-04 15:53:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 16:23:46]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491321163547180, "parent_rev":
"16b0df9c00082444a207bd651996e5cdf8512c54", "commit_rev":
"43c00b6dfca02767efa66d7fb110c7cbf28bc019"}

[commit-bot: I haz the power, 2017-04-04 16:24:42]

Description was changed from

==========
cros: Fix keyboard navigation focus get lost when system tray set to invisible
on oobe

Changes:
(1) add tray->visible() check in WebUILoginView::TakeFocus().
(2) add else branch to avoid an invisible focus stop.

BUG=707977
TEST=test that focus loop works
==========

to

==========
cros: Fix keyboard navigation focus get lost when system tray set to invisible
on oobe

Changes:
(1) add tray->visible() check in WebUILoginView::TakeFocus().
(2) add else branch to avoid an invisible focus stop.

BUG=707977
TEST=test that focus loop works

Review-Url: https://codereview.chromium.org/2794153002
Cr-Commit-Position: refs/heads/master@{#461741}
Committed:
https://chromium.googlesource.com/chromium/src/+/43c00b6dfca02767efa66d7fb110...
==========

[commit-bot: I haz the power, 2017-04-04 16:24:43]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/43c00b6dfca02767efa66d7fb110...

[foolip, 2017-04-06 03:58:02]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2801853003/ by foolip@chromium.org.

The reason for reverting is: AutofillInteractiveTest.AutofillAfterReload became
flaky right after
this landed. The test involves focus (FocusFirstNameField()) and the
change also involves focus, so there is likely a connection.

BUG=708861.