Use ScopedTaskEnvironment instead of MessageLoop in media unit tests.

Use ScopedTaskEnvironment instead of MessageLoop in media unit tests.

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in every unit test that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3Pkk/edit

BUG=708584
R=gab@chromium.org
TBR=liberato@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2801823002
Cr-Commit-Position: refs/heads/master@{#462509}
Committed: https://chromium.googlesource.com/chromium/src/+/4cf067df249b8dbf265eeb944ed7c9b0ef420b08

[fdoray, 2017-04-05 19:46:49]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[fdoray, 2017-04-05 19:46:50]

Description was changed from

==========
Use ScopedTaskEnvironment instead of MessageLoop in media unit tests.

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in every unit test that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3P...

BUG=708584
R=gab@chromium.org
TBR=liberato@chromium.org
==========

to

==========
Use ScopedTaskEnvironment instead of MessageLoop in media unit tests.

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in every unit test that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3P...

BUG=708584
R=gab@chromium.org
TBR=liberato@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[fdoray, 2017-04-05 19:46:51]

gab@: PTAL

The change will then be TBRed to the owner.

[commit-bot: I haz the power, 2017-04-05 19:47:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2017-04-05 20:54:39]

lgtm

[commit-bot: I haz the power, 2017-04-05 21:58:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 21:58:45]

Dry run: This issue passed the CQ dry run.

[liberato (no reviews please), 2017-04-05 22:16:20]

Description was changed from

==========
Use ScopedTaskEnvironment instead of MessageLoop in media unit tests.

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in every unit test that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3P...

BUG=708584
R=gab@chromium.org
TBR=liberato@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Use ScopedTaskEnvironment instead of MessageLoop in media unit tests.

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in every unit test that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3P...

BUG=708584
R=gab@chromium.org
TBR=liberato@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[liberato (no reviews please), 2017-04-05 22:16:20]

liberato@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[liberato (no reviews please), 2017-04-05 22:17:36]

On 2017/04/05 20:54:39, gab wrote:
> lgtm

+dalecurtis, since i'm going ooo and didn't get to this.  this CL looks okay,
assuming that ScopedTaskEnvironment does what i think it does.  didn't have time
to go over the other CL in detail to verify my assumptions, though.

thanks
-fl

[fdoray, 2017-04-06 15:27:53]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2017-04-06 15:28:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 16:48:19]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491492473351520, "parent_rev":
"e60f30d448ad169ebc5c7f1cf45e83da2af33959", "commit_rev":
"4cf067df249b8dbf265eeb944ed7c9b0ef420b08"}

[commit-bot: I haz the power, 2017-04-06 16:49:18]

Description was changed from

==========
Use ScopedTaskEnvironment instead of MessageLoop in media unit tests.

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in every unit test that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3P...

BUG=708584
R=gab@chromium.org
TBR=liberato@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Use ScopedTaskEnvironment instead of MessageLoop in media unit tests.

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in every unit test that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3P...

BUG=708584
R=gab@chromium.org
TBR=liberato@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2801823002
Cr-Commit-Position: refs/heads/master@{#462509}
Committed:
https://chromium.googlesource.com/chromium/src/+/4cf067df249b8dbf265eeb944ed7...
==========

[commit-bot: I haz the power, 2017-04-06 16:49:19]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4cf067df249b8dbf265eeb944ed7...