Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Side by Side Diff: media/remoting/courier_renderer_unittest.cc

Issue 2801823002: Use ScopedTaskEnvironment instead of MessageLoop in media unit tests. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/gpu/ipc/service/gpu_jpeg_decode_accelerator_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/remoting/courier_renderer.h" 5 #include "media/remoting/courier_renderer.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "base/run_loop.h" 8 #include "base/run_loop.h"
9 #include "base/test/scoped_task_environment.h"
9 #include "base/test/simple_test_tick_clock.h" 10 #include "base/test/simple_test_tick_clock.h"
10 #include "base/threading/thread_task_runner_handle.h" 11 #include "base/threading/thread_task_runner_handle.h"
11 #include "media/base/pipeline_status.h" 12 #include "media/base/pipeline_status.h"
12 #include "media/base/renderer_client.h" 13 #include "media/base/renderer_client.h"
13 #include "media/base/test_helpers.h" 14 #include "media/base/test_helpers.h"
14 #include "media/remoting/fake_media_resource.h" 15 #include "media/remoting/fake_media_resource.h"
15 #include "media/remoting/fake_remoter.h" 16 #include "media/remoting/fake_remoter.h"
16 #include "media/remoting/renderer_controller.h" 17 #include "media/remoting/renderer_controller.h"
17 #include "testing/gmock/include/gmock/gmock.h" 18 #include "testing/gmock/include/gmock/gmock.h"
18 #include "testing/gtest/include/gtest/gtest.h" 19 #include "testing/gtest/include/gtest/gtest.h"
(...skipping 302 matching lines...) Expand 10 before | Expand all | Expand 10 after
321 message->set_audio_bytes_decoded(stats.audio_bytes_decoded); 322 message->set_audio_bytes_decoded(stats.audio_bytes_decoded);
322 message->set_video_bytes_decoded(stats.video_bytes_decoded); 323 message->set_video_bytes_decoded(stats.video_bytes_decoded);
323 message->set_video_frames_decoded(stats.video_frames_decoded); 324 message->set_video_frames_decoded(stats.video_frames_decoded);
324 message->set_video_frames_dropped(stats.video_frames_dropped); 325 message->set_video_frames_dropped(stats.video_frames_dropped);
325 message->set_audio_memory_usage(stats.audio_memory_usage); 326 message->set_audio_memory_usage(stats.audio_memory_usage);
326 message->set_video_memory_usage(stats.video_memory_usage); 327 message->set_video_memory_usage(stats.video_memory_usage);
327 OnReceivedRpc(std::move(rpc)); 328 OnReceivedRpc(std::move(rpc));
328 RunPendingTasks(); 329 RunPendingTasks();
329 } 330 }
330 331
331 base::MessageLoop message_loop_; 332 base::test::ScopedTaskEnvironment scoped_task_environment_;
332 std::unique_ptr<RendererController> controller_; 333 std::unique_ptr<RendererController> controller_;
333 std::unique_ptr<RendererClientImpl> render_client_; 334 std::unique_ptr<RendererClientImpl> render_client_;
334 std::unique_ptr<FakeMediaResource> media_resource_; 335 std::unique_ptr<FakeMediaResource> media_resource_;
335 std::unique_ptr<CourierRenderer> renderer_; 336 std::unique_ptr<CourierRenderer> renderer_;
336 base::SimpleTestTickClock* clock_; // Owned by |renderer_|; 337 base::SimpleTestTickClock* clock_; // Owned by |renderer_|;
337 338
338 // RPC handles. 339 // RPC handles.
339 const int receiver_renderer_handle_; 340 const int receiver_renderer_handle_;
340 const int receiver_audio_demuxer_callback_handle_; 341 const int receiver_audio_demuxer_callback_handle_;
341 const int receiver_video_demuxer_callback_handle_; 342 const int receiver_video_demuxer_callback_handle_;
(...skipping 299 matching lines...) Expand 10 before | Expand all | Expand 10 after
641 ASSERT_FALSE(DidEncounterFatalError()); // Not enough measurements. 642 ASSERT_FALSE(DidEncounterFatalError()); // Not enough measurements.
642 IssueStatisticsUpdateRpc(); 643 IssueStatisticsUpdateRpc();
643 clock_->Advance(base::TimeDelta::FromSeconds(1)); 644 clock_->Advance(base::TimeDelta::FromSeconds(1));
644 RunPendingTasks(); 645 RunPendingTasks();
645 } 646 }
646 ASSERT_TRUE(DidEncounterFatalError()); 647 ASSERT_TRUE(DidEncounterFatalError());
647 } 648 }
648 649
649 } // namespace remoting 650 } // namespace remoting
650 } // namespace media 651 } // namespace media
OLDNEW
« no previous file with comments | « media/gpu/ipc/service/gpu_jpeg_decode_accelerator_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698