Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
3 years, 8 months ago by dusan.simicic Modified:
3 years, 8 months ago Reviewers:
Michael Lippautz, ulan CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, v8-mips-ports_googlegroups.com Target Ref:
refs/heads/master Project:
v8 Visibility:
Public. |
DescriptionFix CreateFillerObjectAt() call for 64b platforms
This patch fixes build error for 64bit platforms introduces in
https://codereview.chromium.org/2793323002
Error message from MIPS64 buildbot: error: implicit conversion loses
integer precision: 'long' to 'int' [-Werror,-Wshorten-64-to-32]
BUG=
Review-Url: https://codereview.chromium.org/2801713004
Cr-Commit-Position: refs/heads/master@{#44460}
Committed: https://chromium.googlesource.com/v8/v8/+/b115095ce113fb62da11d7fabbf220953cbf7746
Patch Set 1 #
Created: 3 years, 8 months ago
Messages
Total messages: 16 (12 generated)
dusan.simicic@imgtec.com changed reviewers: + mlippautz@chromium.org, ulan@chromium.org
PTAL
lgtm
The CQ bit was checked by dusan.simicic@imgtec.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dusan.simicic@imgtec.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dusan.simicic@imgtec.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1491512290787070, "parent_rev":
"61df2d90a952066cec6eb20fc0602b5fae749874", "commit_rev":
"b115095ce113fb62da11d7fabbf220953cbf7746"}
Message was sent while issue was closed.
Description was changed from ========== Fix CreateFillerObjectAt() call for 64b platforms This patch fixes build error for 64bit platforms introduces in https://codereview.chromium.org/2793323002 Error message from MIPS64 buildbot: error: implicit conversion loses integer precision: 'long' to 'int' [-Werror,-Wshorten-64-to-32] BUG= ========== to ========== Fix CreateFillerObjectAt() call for 64b platforms This patch fixes build error for 64bit platforms introduces in https://codereview.chromium.org/2793323002 Error message from MIPS64 buildbot: error: implicit conversion loses integer precision: 'long' to 'int' [-Werror,-Wshorten-64-to-32] BUG= Review-Url: https://codereview.chromium.org/2801713004 Cr-Commit-Position: refs/heads/master@{#44460} Committed: https://chromium.googlesource.com/v8/v8/+/b115095ce113fb62da11d7fabbf220953cb... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/b115095ce113fb62da11d7fabbf220953cb... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
