Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2801713004: Fix CreateFillerObjectAt() call for 64b platforms (Closed)

Created:
3 years, 8 months ago by dusan.simicic
Modified:
3 years, 8 months ago
Reviewers:
Michael Lippautz, ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, v8-mips-ports_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Fix CreateFillerObjectAt() call for 64b platforms This patch fixes build error for 64bit platforms introduces in https://codereview.chromium.org/2793323002 Error message from MIPS64 buildbot: error: implicit conversion loses integer precision: 'long' to 'int' [-Werror,-Wshorten-64-to-32] BUG= Review-Url: https://codereview.chromium.org/2801713004 Cr-Commit-Position: refs/heads/master@{#44460} Committed: https://chromium.googlesource.com/v8/v8/+/b115095ce113fb62da11d7fabbf220953cbf7746

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/heap/mark-compact.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
dusan.simicic
PTAL
3 years, 8 months ago (2017-04-06 13:51:17 UTC) #2
Michael Lippautz
lgtm
3 years, 8 months ago (2017-04-06 14:43:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801713004/1
3 years, 8 months ago (2017-04-06 20:58:16 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 20:59:57 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/b115095ce113fb62da11d7fabbf220953cb...

Powered by Google App Engine
This is Rietveld 408576698