Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 2793323002: Reland of [heap] Refactor evacuation verifier (Closed)

Created:
3 years, 8 months ago by Michael Lippautz
Modified:
3 years, 8 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of [heap] Refactor evacuation verifier This reverts commit c766727ae69d43db66415a3483acc0e846b444d7. BUG=chromium:651354 Review-Url: https://codereview.chromium.org/2793323002 Cr-Commit-Position: refs/heads/master@{#44386} Committed: https://chromium.googlesource.com/v8/v8/+/6d89de7b9e5fc3a5f9d0fa2cef51864191d5ff5f

Patch Set 1 : Baseline #

Patch Set 2 : Fix #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -52 lines) Patch
M src/heap/mark-compact.cc View 1 5 chunks +72 lines, -52 lines 1 comment Download

Messages

Total messages: 13 (9 generated)
Michael Lippautz
ptal https://codereview.chromium.org/2793323002/diff/20001/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/2793323002/diff/20001/src/heap/mark-compact.cc#newcode262 src/heap/mark-compact.cc:262: if (p->Contains(space->top())) Previously we used the HeapObjectIterator for ...
3 years, 8 months ago (2017-04-04 14:50:27 UTC) #4
ulan
lgtm
3 years, 8 months ago (2017-04-04 14:52:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2793323002/20001
3 years, 8 months ago (2017-04-04 16:10:04 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 16:12:04 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/6d89de7b9e5fc3a5f9d0fa2cef51864191d...

Powered by Google App Engine
This is Rietveld 408576698