Enable once flaky tests in Chrome OS file manager.

Enable once flaky tests in Chrome OS file manager.

These tests were previously flaky and there seems to be a shared issue.
However, they do not reproduce anymore on the latest master branch.

It reproduced on commit a2b501b65e0987b4f2a23561a4906eb02f955a40 and
it did not reproduce on 577b8f369864082950e5922472780e54317ea2ac.

BUG=699426, 700156, 699083, 698834, 702119, 701923, 699171, 699978, 702119, 699534, 615259, 698772
TEST=none
TBR=fukino@chromium.org

Review-Url: https://codereview.chromium.org/2801573002
Cr-Commit-Position: refs/heads/master@{#463493}
Committed: https://chromium.googlesource.com/chromium/src/+/54a3dd064413a8d341253c27cb944ba739acba2c

[tetsui2, 2017-04-05 07:45:08]

I would verify this again by running the tests multiple times when I leave the
office today.

[fukino, 2017-04-05 08:13:14]

The change is looking good!
Let's check the result of stress test.

[tetsui2, 2017-04-06 00:50:59]

On 2017/04/05 08:13:14, fukino wrote:
> The change is looking good!
> Let's check the result of stress test.

Some tests are still failing. I tried the following command locally.
out/Release/browser_tests --gtest_repeat=100 '--gtest_filter=*FileManager*'

Following tests failed, but others succeeded.

    MultiProfileFileManagerBrowserTest.PRE_BasicDrive
    OpenFileDialog/FileManagerBrowserTest.Test/3
    OpenImageFiles/FileManagerBrowserTest.Test/1

[tetsui2, 2017-04-06 01:24:16]

I tried these failed tests individually for 100 times and they didn't
reproduce...

out/Release/browser_tests --gtest_repeat=100
'--gtest_filter=OpenFileDialog/FileManagerBrowserTest.Test/3'
out/Release/browser_tests --gtest_repeat=100
'--gtest_filter=OpenImageFiles/FileManagerBrowserTest.Test/1'

[fukino, 2017-04-06 02:21:12]

Thank you for the test, tetsui@
Let's revive the tests except for
MultiProfileFileManagerBrowserTest.PRE_BasicDrive
OpenFileDialog/FileManagerBrowserTest.Test/3
OpenImageFiles/FileManagerBrowserTest.Test/1.

[tetsui2, 2017-04-06 04:20:25]

Sorry, the patch set doesn't compile as is and it was my mistake. (L.559)
The result above was wrong, but the number of failing tests are still fewer than
mentioned in crbug.com/702119.
Especially TabindexOpenDialog/FileManagerBrowserTest.Test/0 started to fail all
time.
Let me have more time to investigate the issue and re-run the stress test again.

[tetsui2, 2017-04-07 03:55:18]

I disabled tabindex tests and kept all other tests enabled.

As a result, the following command succeeded:

ninja -j500 -C out/Release browser_tests && time out/Release/browser_tests
'--gtest_filter=*FileManager*' --gtest_repeat=20

[fukino, 2017-04-07 07:21:11]

Thank you!
Can I ask you to run the tests during weekend time and land the reviving patch
on Monday morning JST?
* It will give us more time to verify that the tests are not flaky.
* Landing the patch in the morning will allow us to monitor the flakiness
dashboard after landing the patch.
* If it causes flakiness again, less engineers will be affected on Monday.

The patch itself lgtm.

[tetsui2, 2017-04-07 07:25:13]

> Can I ask you to run the tests during weekend time and land the reviving patch
> on Monday morning JST?

OK, I would run them on the weekend and put in the CQ if everything goes well.

[tetsui2, 2017-04-11 01:04:16]

ninja -j500 -C out/Release browser_tests && time out/Release/browser_tests
'--gtest_filter=*FileManager*' --gtest_repeat=100

I ran the command above and the following tests failed at least once during the
iteration. I also diable them.

    ShareDialog/FileManagerBrowserTest.Test/0
    ShareDialog/FileManagerBrowserTest.Test/1
    SuggestAppDialog/FileManagerBrowserTest.Test/0

[tetsui2, 2017-04-11 01:10:36]

The CQ bit was checked by tetsui@google.com

[tetsui2, 2017-04-11 01:10:37]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/2801573002/#ps60001
(title: "Disable ShareDialog and SuggestAppDialog tests.")

[commit-bot: I haz the power, 2017-04-11 01:11:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 01:51:00]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491873036643040,
"parent_rev": "49f2af88a8984e00c20730a9257493f5c8b40d88", "commit_rev":
"54a3dd064413a8d341253c27cb944ba739acba2c"}

[commit-bot: I haz the power, 2017-04-11 01:51:59]

Description was changed from

==========
Enable once flaky tests in Chrome OS file manager.

These tests were previously flaky and there seems to be a shared issue.
However, they do not reproduce anymore on the latest master branch.

It reproduced on commit a2b501b65e0987b4f2a23561a4906eb02f955a40 and
it did not reproduce on 577b8f369864082950e5922472780e54317ea2ac.

BUG=699426,700156,699083,698834,702119,701923,699171,699978,702119,699534,615259,698772
TEST=none
TBR=fukino@chromium.org
==========

to

==========
Enable once flaky tests in Chrome OS file manager.

These tests were previously flaky and there seems to be a shared issue.
However, they do not reproduce anymore on the latest master branch.

It reproduced on commit a2b501b65e0987b4f2a23561a4906eb02f955a40 and
it did not reproduce on 577b8f369864082950e5922472780e54317ea2ac.

BUG=699426,700156,699083,698834,702119,701923,699171,699978,702119,699534,615259,698772
TEST=none
TBR=fukino@chromium.org

Review-Url: https://codereview.chromium.org/2801573002
Cr-Commit-Position: refs/heads/master@{#463493}
Committed:
https://chromium.googlesource.com/chromium/src/+/54a3dd064413a8d341253c27cb94...
==========

[commit-bot: I haz the power, 2017-04-11 01:52:03]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/54a3dd064413a8d341253c27cb94...