Enable once flaky tests in Chrome OS file manager.

chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include "base/macros.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/chromeos/drive/file_system_util.h"
 #include "chrome/browser/chromeos/file_manager/file_manager_browsertest_base.h"
@@ skipping 160 matching lines @@
         TestParameter(NOT_IN_GUEST_MODE, "renameFileDrive"),
         TestParameter(IN_GUEST_MODE, "renameNewDirectoryDownloads"),
         TestParameter(NOT_IN_GUEST_MODE, "renameNewDirectoryDownloads"),
         TestParameter(NOT_IN_GUEST_MODE, "renameNewDirectoryDrive")));
 
 #if defined(DISABLE_SLOW_FILESAPP_TESTS)
 #define MAYBE_Delete DISABLED_Delete
 #else
 #define MAYBE_Delete Delete
 #endif
-// Flaky: crbug.com/699426
 WRAPPED_INSTANTIATE_TEST_CASE_P(
-    DISABLED_Delete,
+    MAYBE_Delete,
     FileManagerBrowserTest,
     ::testing::Values(
         TestParameter(NOT_IN_GUEST_MODE,
                       "deleteMenuItemIsDisabledWhenNoItemIsSelected"),
         TestParameter(NOT_IN_GUEST_MODE, "deleteOneItemFromToolbar")));
 
 WRAPPED_INSTANTIATE_TEST_CASE_P(
     DISABLED_QuickView,
     FileManagerBrowserTest,
     ::testing::Values(TestParameter(NOT_IN_GUEST_MODE, "openQuickView")));
 
 #if defined(DISABLE_SLOW_FILESAPP_TESTS)
 #define MAYBE_DirectoryTreeContextMenu DISABLED_DirectoryTreeContextMenu
 #else
 #define MAYBE_DirectoryTreeContextMenu DirectoryTreeContextMenu
 #endif
-// Flaky: crbug.com/700156, crbug.com/699083
 WRAPPED_INSTANTIATE_TEST_CASE_P(
-    DISABLED_DirectoryTreeContextMenu,
+    MAYBE_DirectoryTreeContextMenu,
     FileManagerBrowserTest,
     ::testing::Values(
         TestParameter(NOT_IN_GUEST_MODE,
                       "copyFromDirectoryTreeWithContextMenu"),
         TestParameter(IN_GUEST_MODE, "copyFromDirectoryTreeWithContextMenu"),
         TestParameter(NOT_IN_GUEST_MODE,
                       "copyFromDirectoryTreeWithKeyboardShortcut"),
         TestParameter(IN_GUEST_MODE,
                       "copyFromDirectoryTreeWithKeyboardShortcut"),
         TestParameter(NOT_IN_GUEST_MODE,
@@ skipping 39 matching lines @@
         TestParameter(NOT_IN_GUEST_MODE,
                       "createDirectoryFromDirectoryTreeWithoutChangingCurrentDi"
                       "rectory")));
 
 // Fails on official build. http://crbug.com/429294
 #if defined(DISABLE_SLOW_FILESAPP_TESTS) || defined(OFFICIAL_BUILD)
 #define MAYBE_DriveSpecific DISABLED_DriveSpecific
 #else
 #define MAYBE_DriveSpecific DriveSpecific
 #endif
-// Flaky: crbug.com/698834
 WRAPPED_INSTANTIATE_TEST_CASE_P(
-    DISABLED_DriveSpecific,
+    MAYBE_DriveSpecific,
     FileManagerBrowserTest,
     ::testing::Values(
         TestParameter(NOT_IN_GUEST_MODE, "openSidebarRecent"),
         TestParameter(NOT_IN_GUEST_MODE, "openSidebarOffline"),
         TestParameter(NOT_IN_GUEST_MODE, "openSidebarSharedWithMe"),
         TestParameter(NOT_IN_GUEST_MODE, "autocomplete"),
         TestParameter(NOT_IN_GUEST_MODE, "pinFileOnMobileNetwork"),
         TestParameter(NOT_IN_GUEST_MODE, "clickFirstSearchResult"),
         TestParameter(NOT_IN_GUEST_MODE, "pressEnterToSearch")));
 
@@ skipping 29 matching lines @@
     ::testing::Values(TestParameter(IN_GUEST_MODE, "restoreSortColumn"),
                       TestParameter(NOT_IN_GUEST_MODE, "restoreSortColumn"),
                       TestParameter(IN_GUEST_MODE, "restoreCurrentView"),
                       TestParameter(NOT_IN_GUEST_MODE, "restoreCurrentView")));
 
 #if defined(DISABLE_SLOW_FILESAPP_TESTS)
 #define MAYBE_ShareDialog DISABLED_ShareDialog
 #else
 #define MAYBE_ShareDialog ShareDialog
 #endif
-// Flaky: crbug.com/702119.
 WRAPPED_INSTANTIATE_TEST_CASE_P(
     DISABLED_ShareDialog,
     FileManagerBrowserTest,
     ::testing::Values(TestParameter(NOT_IN_GUEST_MODE, "shareFile"),
                       TestParameter(NOT_IN_GUEST_MODE, "shareDirectory")));
 
 #if defined(DISABLE_SLOW_FILESAPP_TESTS)
 #define MAYBE_RestoreGeometry DISABLED_RestoreGeometry
 #else
 #define MAYBE_RestoreGeometry RestoreGeometry
@@ skipping 16 matching lines @@
     FileManagerBrowserTest,
     ::testing::Values(TestParameter(IN_GUEST_MODE, "traverseDownloads"),
                       TestParameter(NOT_IN_GUEST_MODE, "traverseDownloads"),
                       TestParameter(NOT_IN_GUEST_MODE, "traverseDrive")));
 
 #if defined(DISABLE_SLOW_FILESAPP_TESTS)
 #define MAYBE_SuggestAppDialog DISABLED_SuggestAppDialog
 #else
 #define MAYBE_SuggestAppDialog SuggestAppDialog
 #endif
-// Flaky: crbug.com/701923
 WRAPPED_INSTANTIATE_TEST_CASE_P(
     DISABLED_SuggestAppDialog,
     FileManagerBrowserTest,
     ::testing::Values(TestParameter(NOT_IN_GUEST_MODE, "suggestAppDialog")));
 
 #if defined(DISABLE_SLOW_FILESAPP_TESTS)
 #define MAYBE_ExecuteDefaultTaskOnDownloads \
   DISABLED_ExecuteDefaultTaskOnDownloads
 #else
 #define MAYBE_ExecuteDefaultTaskOnDownloads ExecuteDefaultTaskOnDownloads
 #endif
-// Flaky: crbug.com/699171
 WRAPPED_INSTANTIATE_TEST_CASE_P(
-    DISABLED_ExecuteDefaultTaskOnDownloads,
+    MAYBE_ExecuteDefaultTaskOnDownloads,
     FileManagerBrowserTest,
     ::testing::Values(
         TestParameter(NOT_IN_GUEST_MODE, "executeDefaultTaskOnDownloads"),
         TestParameter(IN_GUEST_MODE, "executeDefaultTaskOnDownloads")));
 
 #if defined(DISABLE_SLOW_FILESAPP_TESTS)
 #define MAYBE_ExecuteDefaultTaskOnDrive DISABLED_ExecuteDefaultTaskOnDrive
 #else
 #define MAYBE_ExecuteDefaultTaskOnDrive ExecuteDefaultTaskOnDrive
 #endif
-// Flaky: crbug.com/699978
 WRAPPED_INSTANTIATE_TEST_CASE_P(
-    DISABLED_ExecuteDefaultTaskOnDrive,
+    MAYBE_ExecuteDefaultTaskOnDrive,
     FileManagerBrowserTest,
     ::testing::Values(TestParameter(NOT_IN_GUEST_MODE,
                                     "executeDefaultTaskOnDrive")));
 
 #if defined(DISABLE_SLOW_FILESAPP_TESTS)
 #define MAYBE_DefaultTaskDialog DISABLED_DefaultTaskDialog
 #else
 #define MAYBE_DefaultTaskDialog DefaultTaskDialog
 #endif
 WRAPPED_INSTANTIATE_TEST_CASE_P(
@@ skipping 17 matching lines @@
         TestParameter(NOT_IN_GUEST_MODE, "genericAndNonGenericTasksAreMixed")));
 
 #if defined(DISABLE_SLOW_FILESAPP_TESTS)
 #define MAYBE_FolderShortcuts DISABLED_FolderShortcuts
 #else
 #define MAYBE_FolderShortcuts FolderShortcuts
 #endif
 WRAPPED_INSTANTIATE_TEST_CASE_P(
     MAYBE_FolderShortcuts,
     FileManagerBrowserTest,
-    ::testing::Values(TestParameter(NOT_IN_GUEST_MODE,
-                                    "traverseFolderShortcuts")));
-// Flaky: crbug.com/702119.
-// TestParameter(NOT_IN_GUEST_MODE, "addRemoveFolderShortcuts")));
+    ::testing::Values(
+        TestParameter(NOT_IN_GUEST_MODE, "traverseFolderShortcuts"),
+        TestParameter(NOT_IN_GUEST_MODE, "addRemoveFolderShortcuts")));
 
 // Fails on official build. http://crbug.com/429294
 #if defined(DISABLE_SLOW_FILESAPP_TESTS) || defined(OFFICIAL_BUILD)
 #define MAYBE_SortColumns DISABLED_SortColumns
 #else
 #define MAYBE_SortColumns SortColumns
 #endif
 WRAPPED_INSTANTIATE_TEST_CASE_P(
     MAYBE_SortColumns,
     FileManagerBrowserTest,
@@ skipping 18 matching lines @@
 WRAPPED_INSTANTIATE_TEST_CASE_P(
     MAYBE_TabindexFocus,
     FileManagerBrowserTestWithLegacyEventDispatch,
     ::testing::Values(TestParameter(NOT_IN_GUEST_MODE, "tabindexFocus")));
 
 #if defined(DISABLE_SLOW_FILESAPP_TESTS)
 #define MAYBE_TabindexFocusDownloads DISABLED_TabindexFocusDownloads
 #else
 #define MAYBE_TabindexFocusDownloads TabindexFocusDownloads
 #endif
-// Flaky: crbug.com/699534
 WRAPPED_INSTANTIATE_TEST_CASE_P(
-    DISABLED_TabindexFocusDownloads,
+    MAYBE_TabindexFocusDownloads,
     FileManagerBrowserTestWithLegacyEventDispatch,
     ::testing::Values(TestParameter(NOT_IN_GUEST_MODE,
                                     "tabindexFocusDownloads"),
                       TestParameter(IN_GUEST_MODE, "tabindexFocusDownloads")));
 
 #if defined(DISABLE_SLOW_FILESAPP_TESTS)
 #define MAYBE_TabindexFocusDirectorySelected \
   DISABLED_TabindexFocusDirectorySelected
 #else
 #define MAYBE_TabindexFocusDirectorySelected TabindexFocusDirectorySelected
 #endif
 WRAPPED_INSTANTIATE_TEST_CASE_P(
     MAYBE_TabindexFocusDirectorySelected,
     FileManagerBrowserTestWithLegacyEventDispatch,
     ::testing::Values(TestParameter(NOT_IN_GUEST_MODE,
                                     "tabindexFocusDirectorySelected")));
 
 // Fails on official cros trunk build. http://crbug.com/480491
 #if defined(DISABLE_SLOW_FILESAPP_TESTS) || defined(OFFICIAL_BUILD)
 #define MAYBE_TabindexOpenDialog DISABLED_TabindexOpenDialog
 #else
 #define MAYBE_TabindexOpenDialog TabindexOpenDialog
 #endif
-// Flaky: crbug.com/615259
 WRAPPED_INSTANTIATE_TEST_CASE_P(
     DISABLED_TabindexOpenDialog,
     FileManagerBrowserTest,
     ::testing::Values(
         TestParameter(NOT_IN_GUEST_MODE, "tabindexOpenDialogDrive"),
         TestParameter(NOT_IN_GUEST_MODE, "tabindexOpenDialogDownloads"),
         TestParameter(IN_GUEST_MODE, "tabindexOpenDialogDownloads")));
 
 // Fails on official build. http://crbug.com/482121.
 #if defined(DISABLE_SLOW_FILESAPP_TESTS) || defined(OFFICIAL_BUILD)
 #define MAYBE_TabindexSaveFileDialog DISABLED_TabindexSaveFileDialog
 #else
 #define MAYBE_TabindexSaveFileDialog TabindexSaveFileDialog
 #endif
-// Flaky: crbug.com/615259
 WRAPPED_INSTANTIATE_TEST_CASE_P(
     DISABLED_TabindexSaveFileDialog,
     FileManagerBrowserTest,
     ::testing::Values(
         TestParameter(NOT_IN_GUEST_MODE, "tabindexSaveFileDialogDrive"),
         TestParameter(NOT_IN_GUEST_MODE, "tabindexSaveFileDialogDownloads"),
         TestParameter(IN_GUEST_MODE, "tabindexSaveFileDialogDownloads")));
 
 #if defined(DISABLE_SLOW_FILESAPP_TESTS) || defined(OFFICIAL_BUILD)
 #define MAYBE_OpenFileDialog DISABLED_OpenFileDialog
@@ skipping 31 matching lines @@
         TestParameter(NOT_IN_GUEST_MODE, "copyBetweenWindowsUsbToDrive"),
         TestParameter(NOT_IN_GUEST_MODE, "copyBetweenWindowsDriveToLocal"),
         TestParameter(NOT_IN_GUEST_MODE, "copyBetweenWindowsDriveToUsb"),
         TestParameter(NOT_IN_GUEST_MODE, "copyBetweenWindowsUsbToLocal")));
 
 #if defined(DISABLE_SLOW_FILESAPP_TESTS)
 #define MAYBE_ShowGridView DISABLED_ShowGridView
 #else
 #define MAYBE_ShowGridView ShowGridView
 #endif
-// Flaky: crbug.com/698772
 WRAPPED_INSTANTIATE_TEST_CASE_P(
-    DISABLED_ShowGridView,
+    MAYBE_ShowGridView,
     FileManagerBrowserTest,
     ::testing::Values(TestParameter(NOT_IN_GUEST_MODE, "showGridViewDownloads"),
                       TestParameter(IN_GUEST_MODE, "showGridViewDownloads"),
                       TestParameter(NOT_IN_GUEST_MODE, "showGridViewDrive")));
 
 #if defined(DISABLE_SLOW_FILESAPP_TESTS)
 #define MAYBE_Providers DISABLED_Providers
 #else
 #define MAYBE_Providers Providers
 #endif
 WRAPPED_INSTANTIATE_TEST_CASE_P(
     MAYBE_Providers,
     FileManagerBrowserTest,
     ::testing::Values(
         TestParameter(NOT_IN_GUEST_MODE, "requestMount"),
         TestParameter(NOT_IN_GUEST_MODE, "requestMountMultipleMounts"),
-        TestParameter(NOT_IN_GUEST_MODE, "requestMountSourceDevice")));
-// Flaky: crbug.com/702119.
-// TestParameter(NOT_IN_GUEST_MODE, "requestMountSourceFile")));
+        TestParameter(NOT_IN_GUEST_MODE, "requestMountSourceDevice"),
+        TestParameter(NOT_IN_GUEST_MODE, "requestMountSourceFile")));
 
 #if defined(DISABLE_SLOW_FILESAPP_TESTS)
 #define MAYBE_GearMenu DISABLED_GearMenu
 #else
 #define MAYBE_GearMenu GearMenu
 #endif
 WRAPPED_INSTANTIATE_TEST_CASE_P(
     DISABLED_GearMenu,
     FileManagerBrowserTest,
     ::testing::Values(
@@ skipping 126 matching lines @@
 
 IN_PROC_BROWSER_TEST_F(MultiProfileFileManagerBrowserTest, MAYBE_BasicDrive) {
   AddAllUsers();
 
   // Sanity check that normal operations work in multi-profile setting as well.
   set_test_case_name("keyboardCopyDrive");
   StartTest();
 }
 
 }  // namespace file_manager