Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: milo/appengine/common/acl.go

Issue 2801463002: Milo: Use custom config caching layer (Closed)
Patch Set: Review: Remove double logging Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « milo/appengine/buildbucket/builder_test.go ('k') | milo/appengine/common/config.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/appengine/common/acl.go
diff --git a/milo/appengine/common/acl.go b/milo/appengine/common/acl.go
index eb9fcef3e7e517945231eac95237e305df8519c6..ecb709f1b0c806c4fd2af5465323c5c54d3b7058 100644
--- a/milo/appengine/common/acl.go
+++ b/milo/appengine/common/acl.go
@@ -35,9 +35,9 @@ func IsAllowed(c context.Context, project string) (bool, error) {
// IsAllowedInternal is a shorthand for checking to see if the user is a reader
// of a magic project named "chrome".
func IsAllowedInternal(c context.Context) (bool, error) {
- settings, err := GetSettings(c)
- if err != nil {
- return false, err
+ settings := GetSettings(c)
+ if settings.Buildbot.InternalReader == "" {
+ return false, nil
}
return auth.IsMember(c, settings.Buildbot.InternalReader)
}
« no previous file with comments | « milo/appengine/buildbucket/builder_test.go ('k') | milo/appengine/common/config.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698