Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: milo/appengine/buildbucket/builder_test.go

Issue 2801463002: Milo: Use custom config caching layer (Closed)
Patch Set: Review: Remove double logging Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « milo/appengine/buildbucket/builder.go ('k') | milo/appengine/common/acl.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/appengine/buildbucket/builder_test.go
diff --git a/milo/appengine/buildbucket/builder_test.go b/milo/appengine/buildbucket/builder_test.go
index e89f28a61c9aef0bdb9178b3eacb6f852381c162..243369f922b164c16fad1cf06ef988e12504b5c7 100644
--- a/milo/appengine/buildbucket/builder_test.go
+++ b/milo/appengine/buildbucket/builder_test.go
@@ -18,6 +18,7 @@ import (
"github.com/luci/luci-go/common/clock/testclock"
memcfg "github.com/luci/luci-go/common/config/impl/memory"
"github.com/luci/luci-go/luci_config/server/cfgclient/backend/testconfig"
+ "github.com/luci/luci-go/milo/appengine/common"
"golang.org/x/net/context"
. "github.com/smartystreets/goconvey/convey"
@@ -37,6 +38,9 @@ func TestBuilder(t *testing.T) {
c := memory.UseWithAppID(context.Background(), "dev~luci-milo")
c, _ = testclock.UseTime(c, time.Date(2016, time.March, 14, 11, 0, 0, 0, time.UTC))
c = testconfig.WithCommonClient(c, memcfg.New(bktConfigFull))
+ // Update the service config so that the settings are loaded.
+ err := common.UpdateServiceConfig(c)
+ So(err, ShouldBeNil)
for _, tc := range testCases {
tc := tc
« no previous file with comments | « milo/appengine/buildbucket/builder.go ('k') | milo/appengine/common/acl.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698