Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: milo/appengine/common/acl.go

Issue 2801463002: Milo: Use custom config caching layer (Closed)
Patch Set: Review: Remove double logging Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « milo/appengine/buildbucket/builder_test.go ('k') | milo/appengine/common/config.go » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The LUCI Authors. All rights reserved. 1 // Copyright 2016 The LUCI Authors. All rights reserved.
2 // Use of this source code is governed under the Apache License, Version 2.0 2 // Use of this source code is governed under the Apache License, Version 2.0
3 // that can be found in the LICENSE file. 3 // that can be found in the LICENSE file.
4 4
5 package common 5 package common
6 6
7 import ( 7 import (
8 "golang.org/x/net/context" 8 "golang.org/x/net/context"
9 9
10 "github.com/luci/luci-go/luci_config/common/cfgtypes" 10 "github.com/luci/luci-go/luci_config/common/cfgtypes"
(...skipping 17 matching lines...) Expand all
28 case access.ErrNoAccess: 28 case access.ErrNoAccess:
29 return false, nil 29 return false, nil
30 default: 30 default:
31 return false, err 31 return false, err
32 } 32 }
33 } 33 }
34 34
35 // IsAllowedInternal is a shorthand for checking to see if the user is a reader 35 // IsAllowedInternal is a shorthand for checking to see if the user is a reader
36 // of a magic project named "chrome". 36 // of a magic project named "chrome".
37 func IsAllowedInternal(c context.Context) (bool, error) { 37 func IsAllowedInternal(c context.Context) (bool, error) {
38 » settings, err := GetSettings(c) 38 » settings := GetSettings(c)
39 » if err != nil { 39 » if settings.Buildbot.InternalReader == "" {
40 » » return false, err 40 » » return false, nil
41 } 41 }
42 return auth.IsMember(c, settings.Buildbot.InternalReader) 42 return auth.IsMember(c, settings.Buildbot.InternalReader)
43 } 43 }
OLDNEW
« no previous file with comments | « milo/appengine/buildbucket/builder_test.go ('k') | milo/appengine/common/config.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698