Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2801443002: Filter extra output introduced by updating proguard (Closed)

Created:
3 years, 8 months ago by F
Modified:
3 years, 8 months ago
Reviewers:
jbudorick, agrieve
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Filter extra output introduced by updating proguard This CL filters encoded binary protobuf signaled by "***BINARY RUN STATS***" and program class information signaled by "ProgramClass:". This extra output is introduced by updating proguard. BUG=674152 Review-Url: https://codereview.chromium.org/2801443002 Cr-Commit-Position: refs/heads/master@{#462620} Committed: https://chromium.googlesource.com/chromium/src/+/749473a927734754dfcb323b16bdf747b7248d5a

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Patch Set 3 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M build/android/gyp/util/proguard_util.py View 1 2 2 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 31 (20 generated)
F
Hi Andrew, PTAL. Thanks!
3 years, 8 months ago (2017-04-04 19:41:31 UTC) #4
agrieve
lgtm https://codereview.chromium.org/2801443002/diff/1/build/android/gyp/util/proguard_util.py File build/android/gyp/util/proguard_util.py (right): https://codereview.chromium.org/2801443002/diff/1/build/android/gyp/util/proguard_util.py#newcode22 build/android/gyp/util/proguard_util.py:22: self._to_ignore_next_line = False nit: _to_ignore_next_line -> _ignore_next_line
3 years, 8 months ago (2017-04-04 20:05:51 UTC) #6
F
Thanks Andrew! PTAL submitting soon https://codereview.chromium.org/2801443002/diff/1/build/android/gyp/util/proguard_util.py File build/android/gyp/util/proguard_util.py (right): https://codereview.chromium.org/2801443002/diff/1/build/android/gyp/util/proguard_util.py#newcode22 build/android/gyp/util/proguard_util.py:22: self._to_ignore_next_line = False On ...
3 years, 8 months ago (2017-04-04 20:38:07 UTC) #7
jbudorick
There are a bunch of other lines that show up in the build log as ...
3 years, 8 months ago (2017-04-04 20:39:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801443002/20001
3 years, 8 months ago (2017-04-04 20:39:54 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/415056)
3 years, 8 months ago (2017-04-04 23:29:07 UTC) #14
F
Thanks Andrew & John! PTAL This CL now also filters "ProgramClass" output. At the moment, ...
3 years, 8 months ago (2017-04-06 15:00:22 UTC) #18
agrieve
On 2017/04/06 15:00:22, F wrote: > Thanks Andrew & John! PTAL > > This CL ...
3 years, 8 months ago (2017-04-06 15:58:47 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801443002/40001
3 years, 8 months ago (2017-04-06 19:58:09 UTC) #27
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/749473a927734754dfcb323b16bdf747b7248d5a
3 years, 8 months ago (2017-04-06 21:12:32 UTC) #30
jbudorick
3 years, 8 months ago (2017-04-06 22:38:53 UTC) #31
Message was sent while issue was closed.
On 2017/04/06 15:58:47, agrieve wrote:
> On 2017/04/06 15:00:22, F wrote:
> > Thanks Andrew & John! PTAL
> > 
> > This CL now also filters "ProgramClass" output. At the moment, the only
output
> > is "Printing mapping to". I think that's useful to keep around. WDUT?
> 
> I'd probably silence that as well, but don't really care at all. Probably not
> worth spending any more time on. lgtm

I'd lean silence but we can address that later as necessary.

Powered by Google App Engine
This is Rietveld 408576698