Filter extra output introduced by updating proguard

Filter extra output introduced by updating proguard

This CL filters encoded binary protobuf signaled by "***BINARY RUN
STATS***" and program class information signaled by "ProgramClass:".
This extra output is introduced by updating proguard.

BUG=674152
Review-Url: https://codereview.chromium.org/2801443002
Cr-Commit-Position: refs/heads/master@{#462620}
Committed: https://chromium.googlesource.com/chromium/src/+/749473a927734754dfcb323b16bdf747b7248d5a

[F, 2017-04-04 19:40:26]

Description was changed from

==========
Filter RunStatsWriter output in proguard output

BUG=674152
==========

to

==========
Filter RunStatsWriter output in proguard output

RunStatsWriter in Proguard always prints "***BINARY RUN STATS***: "
followed by the encoded binary protobuf. This CL filters this output so
it does not clog the build log.

BUG=674152
==========

[F, 2017-04-04 19:41:18]

The CQ bit was checked by zpeng@chromium.org to run a CQ dry run

[F, 2017-04-04 19:41:31]

zpeng@chromium.org changed reviewers:
+ agrieve@chromium.org

[F, 2017-04-04 19:41:31]

Hi Andrew, PTAL. Thanks!

[commit-bot: I haz the power, 2017-04-04 19:41:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[agrieve, 2017-04-04 20:05:51]

lgtm

https://codereview.chromium.org/2801443002/diff/1/build/android/gyp/util/prog...
File build/android/gyp/util/proguard_util.py (right):

https://codereview.chromium.org/2801443002/diff/1/build/android/gyp/util/prog...
build/android/gyp/util/proguard_util.py:22: self._to_ignore_next_line = False
nit: _to_ignore_next_line -> _ignore_next_line

[F, 2017-04-04 20:38:07]

Thanks Andrew! PTAL

submitting soon

https://codereview.chromium.org/2801443002/diff/1/build/android/gyp/util/prog...
File build/android/gyp/util/proguard_util.py (right):

https://codereview.chromium.org/2801443002/diff/1/build/android/gyp/util/prog...
build/android/gyp/util/proguard_util.py:22: self._to_ignore_next_line = False
On 2017/04/04 20:05:51, agrieve wrote:
> nit: _to_ignore_next_line -> _ignore_next_line

Done.

[F, 2017-04-04 20:38:49]

The CQ bit was checked by zpeng@chromium.org

[F, 2017-04-04 20:38:50]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2801443002/#ps20001
(title: "Address comments")

[jbudorick, 2017-04-04 20:39:16]

jbudorick@chromium.org changed reviewers:
+ jbudorick@chromium.org

[jbudorick, 2017-04-04 20:39:17]

There are a bunch of other lines that show up in the build log as well, not just
the binary protobuf lines. Should we filter those as well?

[commit-bot: I haz the power, 2017-04-04 20:39:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 23:29:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 23:29:07]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[F, 2017-04-06 14:55:46]

Description was changed from

==========
Filter RunStatsWriter output in proguard output

RunStatsWriter in Proguard always prints "***BINARY RUN STATS***: "
followed by the encoded binary protobuf. This CL filters this output so
it does not clog the build log.

BUG=674152
==========

to

==========
Filter extra output introduced by updating proguard

This CL filters encoded binary protobuf signaled by "***BINARY RUN
STATS***" and program class information signaled by "ProgramClass:".
This extra output is introduced by updating proguard.

BUG=674152
==========

[F, 2017-04-06 14:55:57]

The CQ bit was checked by zpeng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 14:56:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[F, 2017-04-06 15:00:22]

Thanks Andrew & John! PTAL

This CL now also filters "ProgramClass" output. At the moment, the only output
is "Printing mapping to". I think that's useful to keep around. WDUT?

[commit-bot: I haz the power, 2017-04-06 15:13:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 15:13:50]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[F, 2017-04-06 15:17:21]

The CQ bit was checked by zpeng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 15:17:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[agrieve, 2017-04-06 15:58:47]

On 2017/04/06 15:00:22, F wrote:
> Thanks Andrew & John! PTAL
> 
> This CL now also filters "ProgramClass" output. At the moment, the only output
> is "Printing mapping to". I think that's useful to keep around. WDUT?

I'd probably silence that as well, but don't really care at all. Probably not
worth spending any more time on. lgtm

[commit-bot: I haz the power, 2017-04-06 16:35:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 16:35:42]

Dry run: This issue passed the CQ dry run.

[F, 2017-04-06 19:57:00]

The CQ bit was checked by zpeng@chromium.org

[commit-bot: I haz the power, 2017-04-06 19:58:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 21:11:37]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491508620882420,
"parent_rev": "991302e9a650020672202c472a3998a4afdfede2", "commit_rev":
"749473a927734754dfcb323b16bdf747b7248d5a"}

[commit-bot: I haz the power, 2017-04-06 21:12:31]

Description was changed from

==========
Filter extra output introduced by updating proguard

This CL filters encoded binary protobuf signaled by "***BINARY RUN
STATS***" and program class information signaled by "ProgramClass:".
This extra output is introduced by updating proguard.

BUG=674152
==========

to

==========
Filter extra output introduced by updating proguard

This CL filters encoded binary protobuf signaled by "***BINARY RUN
STATS***" and program class information signaled by "ProgramClass:".
This extra output is introduced by updating proguard.

BUG=674152

Review-Url: https://codereview.chromium.org/2801443002
Cr-Commit-Position: refs/heads/master@{#462620}
Committed:
https://chromium.googlesource.com/chromium/src/+/749473a927734754dfcb323b16bd...
==========

[commit-bot: I haz the power, 2017-04-06 21:12:32]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/749473a927734754dfcb323b16bd...

[jbudorick, 2017-04-06 22:38:53]

On 2017/04/06 15:58:47, agrieve wrote:
> On 2017/04/06 15:00:22, F wrote:
> > Thanks Andrew & John! PTAL
> > 
> > This CL now also filters "ProgramClass" output. At the moment, the only
output
> > is "Printing mapping to". I think that's useful to keep around. WDUT?
> 
> I'd probably silence that as well, but don't really care at all. Probably not
> worth spending any more time on. lgtm

I'd lean silence but we can address that later as necessary.