cc : Delete layer's draw blend mode

cc : Delete layer's draw blend mode

Since its always the default. Whenever there is a non-default blend
mode, render surface takes care of blending

BUG=709269
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2801383002
Cr-Commit-Position: refs/heads/master@{#463330}
Committed: https://chromium.googlesource.com/chromium/src/+/815ffdb83a680ac0e348f1305d7051a574f17b20

[jaydasika, 2017-04-07 19:08:46]

Description was changed from

==========
cc : Delete layer's draw blend mode

Since its always the default. Whenever there is a non-default blend
mode, render surface takes care of blending

BUG=709269
==========

to

==========
cc : Delete layer's draw blend mode

Since its always the default. Whenever there is a non-default blend
mode, render surface takes care of blending

BUG=709269
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[jaydasika, 2017-04-07 19:09:38]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[jaydasika, 2017-04-07 19:09:49]

jaydasika@chromium.org changed reviewers:
+ ajuma@chromium.org, weiliangc@chromium.org

[jaydasika, 2017-04-07 19:09:50]

PTAL

[commit-bot: I haz the power, 2017-04-07 19:10:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 20:28:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 20:28:08]

Dry run: This issue passed the CQ dry run.

[jaydasika, 2017-04-07 21:23:17]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 21:23:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 22:24:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 22:24:51]

Dry run: This issue passed the CQ dry run.

[weiliangc, 2017-04-10 15:42:20]

https://codereview.chromium.org/2801383002/diff/20001/cc/layers/layer_impl.cc
File cc/layers/layer_impl.cc (right):

https://codereview.chromium.org/2801383002/diff/20001/cc/layers/layer_impl.cc...
cc/layers/layer_impl.cc:172: draw_properties().opacity, SkBlendMode::kSrcOver,
Do we ever set SharedQuadState's blend mode to anything other than kSrcOver? Can
we delete the draw blend mode in shared quad state too?

[jaydasika, 2017-04-10 16:29:33]

https://codereview.chromium.org/2801383002/diff/20001/cc/layers/layer_impl.cc
File cc/layers/layer_impl.cc (right):

https://codereview.chromium.org/2801383002/diff/20001/cc/layers/layer_impl.cc...
cc/layers/layer_impl.cc:172: draw_properties().opacity, SkBlendMode::kSrcOver,
On 2017/04/10 15:42:20, weiliangc wrote:
> Do we ever set SharedQuadState's blend mode to anything other than kSrcOver?
Can
> we delete the draw blend mode in shared quad state too?

We can set it to something other than kSrcOver when its called by
RenderSurfaceImpl instead of LayerImpl.

[weiliangc, 2017-04-10 17:05:32]

On 2017/04/10 at 16:29:33, jaydasika wrote:
> https://codereview.chromium.org/2801383002/diff/20001/cc/layers/layer_impl.cc
> File cc/layers/layer_impl.cc (right):
> 
>
https://codereview.chromium.org/2801383002/diff/20001/cc/layers/layer_impl.cc...
> cc/layers/layer_impl.cc:172: draw_properties().opacity, SkBlendMode::kSrcOver,
> On 2017/04/10 15:42:20, weiliangc wrote:
> > Do we ever set SharedQuadState's blend mode to anything other than kSrcOver?
Can
> > we delete the draw blend mode in shared quad state too?
> 
> We can set it to something other than kSrcOver when its called by
RenderSurfaceImpl instead of LayerImpl.

I see. Thanks. LGTM

[jaydasika, 2017-04-10 17:08:10]

The CQ bit was checked by jaydasika@chromium.org

[commit-bot: I haz the power, 2017-04-10 17:08:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 18:19:53]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491844090682800,
"parent_rev": "f23b1c1dcfe30977bf66bdc90584fe59ab6441ea", "commit_rev":
"815ffdb83a680ac0e348f1305d7051a574f17b20"}

[commit-bot: I haz the power, 2017-04-10 18:20:53]

Description was changed from

==========
cc : Delete layer's draw blend mode

Since its always the default. Whenever there is a non-default blend
mode, render surface takes care of blending

BUG=709269
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc : Delete layer's draw blend mode

Since its always the default. Whenever there is a non-default blend
mode, render surface takes care of blending

BUG=709269
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2801383002
Cr-Commit-Position: refs/heads/master@{#463330}
Committed:
https://chromium.googlesource.com/chromium/src/+/815ffdb83a680ac0e348f1305d70...
==========

[commit-bot: I haz the power, 2017-04-10 18:20:54]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/815ffdb83a680ac0e348f1305d70...