Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: cc/layers/layer_impl.cc

Issue 2801383002: cc : Delete layer's draw blend mode (Closed)
Patch Set: . Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layers/layer_impl.h ('k') | cc/layers/video_layer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/layer_impl.cc
diff --git a/cc/layers/layer_impl.cc b/cc/layers/layer_impl.cc
index d372baf6bca6ed2999fb7bcc5abf3d2a520539dc..705b9ffd6ca5a72a786da8579804e1d0f91667f1 100644
--- a/cc/layers/layer_impl.cc
+++ b/cc/layers/layer_impl.cc
@@ -70,7 +70,6 @@ LayerImpl::LayerImpl(LayerTreeImpl* tree_impl, int id)
was_ever_ready_since_last_transform_animation_(true),
background_color_(0),
safe_opaque_background_color_(0),
- draw_blend_mode_(SkBlendMode::kSrcOver),
transform_tree_index_(TransformTree::kInvalidNodeId),
effect_tree_index_(EffectTree::kInvalidNodeId),
clip_tree_index_(ClipTree::kInvalidNodeId),
@@ -151,7 +150,7 @@ void LayerImpl::PopulateSharedQuadState(SharedQuadState* state) const {
state->SetAll(draw_properties_.target_space_transform, bounds(),
draw_properties_.visible_layer_rect, draw_properties_.clip_rect,
draw_properties_.is_clipped, draw_properties_.opacity,
- draw_blend_mode_, GetSortingContextId());
+ SkBlendMode::kSrcOver, GetSortingContextId());
}
void LayerImpl::PopulateScaledSharedQuadState(
@@ -170,7 +169,7 @@ void LayerImpl::PopulateScaledSharedQuadState(
state->SetAll(scaled_draw_transform, scaled_bounds, scaled_visible_layer_rect,
draw_properties().clip_rect, draw_properties().is_clipped,
- draw_properties().opacity, draw_blend_mode_,
+ draw_properties().opacity, SkBlendMode::kSrcOver,
weiliangc 2017/04/10 15:42:20 Do we ever set SharedQuadState's blend mode to any
jaydasika 2017/04/10 16:29:33 We can set it to something other than kSrcOver whe
GetSortingContextId());
}
@@ -331,7 +330,6 @@ void LayerImpl::PushPropertiesTo(LayerImpl* layer) {
layer->touch_event_handler_region_ = touch_event_handler_region_;
layer->background_color_ = background_color_;
layer->safe_opaque_background_color_ = safe_opaque_background_color_;
- layer->draw_blend_mode_ = draw_blend_mode_;
layer->position_ = position_;
layer->transform_tree_index_ = transform_tree_index_;
layer->effect_tree_index_ = effect_tree_index_;
« no previous file with comments | « cc/layers/layer_impl.h ('k') | cc/layers/video_layer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698