Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 2801363002: Use hasReceivedUserGesture for collecting vibrate metrics on user gesture. (Closed)

Created:
3 years, 8 months ago by gogerald1
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Use hasReceivedUserGesture for collecting vibrate metrics on user gesture. This is to be consistent with our intended implementation & better measure the metrics on vibrate blocking. The Intent to Deprecate thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/QGcpjisxtik BUG=704650 Review-Url: https://codereview.chromium.org/2804913004 Cr-Commit-Position: refs/heads/master@{#462838} (cherry picked from commit 8ff07186c17d708d63ce2bf9fc6d6a9bca92cdae) Review-Url: https://codereview.chromium.org/2801363002 . Cr-Commit-Position: refs/branch-heads/3029@{#630} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/b6390f2e420693475ecdc1d31b91ee1159202e5a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
gogerald1
3 years, 8 months ago (2017-04-07 18:36:03 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b6390f2e420693475ecdc1d31b91ee1159202e5a.

Powered by Google App Engine
This is Rietveld 408576698