Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2804913004:
Use hasReceivedUserGesture for collecting vibrate metrics on user gesture. (Closed)
DescriptionUse hasReceivedUserGesture for collecting vibrate metrics on user gesture.
This is to be consistent with our intended implementation & better
measure the metrics on vibrate blocking.
The Intent to Deprecate thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/QGcpjisxtik
BUG=704650
Review-Url: https://codereview.chromium.org/2804913004
Cr-Commit-Position: refs/heads/master@{#462838}
Committed: https://chromium.googlesource.com/chromium/src/+/8ff07186c17d708d63ce2bf9fc6d6a9bca92cdae
Patch Set 1 #Patch Set 2 : Use hasReceivedUserGesture for vibrate metrics collecting. #
Messages
Total messages: 23 (12 generated)
The CQ bit was checked by binlu@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Use hasReceivedUserGesture for collecting vibrate metrics on user gesture. This is to be consistent with our intended implementation & better measure the metrics on vibrate blocking. The Intent to Deprecate thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/QGcpjisxtik BUG=704650 ========== to ========== Use hasReceivedUserGesture for collecting vibrate metrics on user gesture. This is to be consistent with our intended implementation & better measure the metrics on vibrate blocking. The Intent to Deprecate thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/QGcpjisxtik BUG=704650 ==========
binlu@google.com changed reviewers: + ojan@chromium.org, rbyers@chromium.org
Moving the change on userGesture for better collecting metrics into a separate CL (out of https://codereview.chromium.org/2778693004/), so that we might be able to merge it into M58.
lgtm +mustaq@chromium FYI, mustaq is starting work on user gesture related things, so please CC him on future patches.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by binlu@chromium.org
Sure, I'll cc mustaq on feature patches. Thanks for the review! On 2017/04/06 20:51:02, ojan wrote: > lgtm > > +mustaq@chromium > > FYI, mustaq is starting work on user gesture related things, so please CC him on > future patches.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
binlu@chromium.org changed reviewers: + mvanouwerkerk@chromium.org
+mvanouwerkerkï¼ for owner approval.
rslgtm I have no idea exactly how hasReceivedUserGesture differs though, is has no documentation.
rs lgtm
The CQ bit was checked by binlu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491565128338400,
"parent_rev": "5daaa56488f8ae678e47661e861e8e0c6db8e2a8", "commit_rev":
"8ff07186c17d708d63ce2bf9fc6d6a9bca92cdae"}
Message was sent while issue was closed.
Description was changed from ========== Use hasReceivedUserGesture for collecting vibrate metrics on user gesture. This is to be consistent with our intended implementation & better measure the metrics on vibrate blocking. The Intent to Deprecate thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/QGcpjisxtik BUG=704650 ========== to ========== Use hasReceivedUserGesture for collecting vibrate metrics on user gesture. This is to be consistent with our intended implementation & better measure the metrics on vibrate blocking. The Intent to Deprecate thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/QGcpjisxtik BUG=704650 Review-Url: https://codereview.chromium.org/2804913004 Cr-Commit-Position: refs/heads/master@{#462838} Committed: https://chromium.googlesource.com/chromium/src/+/8ff07186c17d708d63ce2bf9fc6d... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/8ff07186c17d708d63ce2bf9fc6d...
Message was sent while issue was closed.
Thanks Michael for the review! For more background, here are two CLs that added hasReceivedUserGesture: https://codereview.chromium.org/2408333004 https://codereview.chromium.org/2392773002 On 2017/04/07 10:37:18, Michael van Ouwerkerk wrote: > rslgtm > > I have no idea exactly how hasReceivedUserGesture differs though, is has no > documentation. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
