Remove stale gn arg to avoid undeclared argument warning.

Remove stale gn arg to avoid undeclared argument warning.

v8_enable_inspector was removed recently. Clean up remnants.

Also fixes a dependent gn check issue which blocked submission,
http://crrev.com/462467 did not update GN deps for new header.

BUG=645890, 708965
TEST=none

Review-Url: https://codereview.chromium.org/2801123002
Cr-Commit-Position: refs/heads/master@{#462652}
Committed: https://chromium.googlesource.com/chromium/src/+/fd6c74121796da3012155a89c16ada1332736a06

[DaleCurtis, 2017-04-06 18:27:50]

dalecurtis@chromium.org changed reviewers:
+ brucedawson@chromium.org

[brucedawson, 2017-04-06 18:51:39]

lgtm

[DaleCurtis, 2017-04-06 18:59:57]

Description was changed from

==========
Remove stale gn arg to avoid undeclared argument warning.

Seems this was removed recently. Clean up build file remnants.

BUG=645890
TEST=none
==========

to

==========
Remove stale gn arg to avoid undeclared argument warning.

v8_enable_inspector was removed recently. Clean up remnants.

BUG=645890
TEST=none
==========

[Michael Achenbach, 2017-04-06 19:02:35]

machenbach@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Achenbach, 2017-04-06 19:02:35]

lgtm, thanks!

[Michael Achenbach, 2017-04-06 19:03:39]

On 2017/04/06 19:02:35, Michael Achenbach wrote:
> lgtm, thanks!

Might need to wait with landing this for a day more, as V8 might get reverted to
the last canary. And then the canary shouldn't break.

[DaleCurtis, 2017-04-06 19:05:15]

Hmm, okay, I'll let you handle the submission then, feel free to CQ when you
think it's ready.

[Michael Achenbach, 2017-04-06 19:06:46]

On 2017/04/06 19:05:15, DaleCurtis wrote:
> Hmm, okay, I'll let you handle the submission then, feel free to CQ when you
> think it's ready.

I try to remember tomorrow during EMEA daytime, if not please land tomorrow.

[Michael Achenbach, 2017-04-06 19:09:45]

Or how about this: Lets land this now, since the warning seems to be annoying.

CC hablich@: in case of a canary revert containing
https://chromium.googlesource.com/v8/v8.git/+/d96fbee9aa35b92afe59179bb02d935...,
this needs to be reverted too.

[Michael Achenbach, 2017-04-06 19:10:38]

machenbach@chromium.org changed reviewers:
+ kozyatinskiy@chromium.org, yangguo@chromium.org

[Michael Achenbach, 2017-04-06 19:10:39]

+ Aleksey, Yang

[Michael Achenbach, 2017-04-06 19:10:51]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2017-04-06 19:11:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yang, 2017-04-06 19:12:00]

On 2017/04/06 19:11:30, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

lgtm

[commit-bot: I haz the power, 2017-04-06 19:19:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 19:19:04]

Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[kozy, 2017-04-06 19:33:32]

lgtm

[DaleCurtis, 2017-04-06 19:33:40]

The CQ bit was checked by dalecurtis@chromium.org

[Michael Achenbach, 2017-04-06 19:34:31]

On 2017/04/06 19:33:32, kozy wrote:
> lgtm

Those errors look weird. Aleksey, any idea? I'll be off now for today...

[commit-bot: I haz the power, 2017-04-06 19:34:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[DaleCurtis, 2017-04-06 19:35:57]

I think it's some unrelated stuff.

[commit-bot: I haz the power, 2017-04-06 19:40:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 19:40:15]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[DaleCurtis, 2017-04-06 19:51:05]

Hmm, doesn't repro locally, but error looks legit, so adding BUILD.gn DEP for
video_codecs API.

+ilnik in case this is incorrect https://codereview.chromium.org/2797303004

[DaleCurtis, 2017-04-06 19:51:35]

dalecurtis@chromium.org changed reviewers:
+ ilnik@chromium.org

[DaleCurtis, 2017-04-06 19:51:36]

Really +ilnik

[DaleCurtis, 2017-04-06 19:51:58]

The CQ bit was checked by dalecurtis@chromium.org

[DaleCurtis, 2017-04-06 19:51:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org, brucedawson@chromium.org, yangguo@chromium.org,
machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/2801123002/#ps20001
(title: "Fix gn check?")

[DaleCurtis, 2017-04-06 19:52:28]

Description was changed from

==========
Remove stale gn arg to avoid undeclared argument warning.

v8_enable_inspector was removed recently. Clean up remnants.

BUG=645890
TEST=none
==========

to

==========
Remove stale gn arg to avoid undeclared argument warning.

v8_enable_inspector was removed recently. Clean up remnants.

BUG=645890,708965
TEST=none
==========

[commit-bot: I haz the power, 2017-04-06 19:53:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[DaleCurtis, 2017-04-06 19:53:53]

Description was changed from

==========
Remove stale gn arg to avoid undeclared argument warning.

v8_enable_inspector was removed recently. Clean up remnants.

BUG=645890,708965
TEST=none
==========

to

==========
Remove stale gn arg to avoid undeclared argument warning.

v8_enable_inspector was removed recently. Clean up remnants.

Also fixes a dependent gn check issue which blocked submission,
http://crrev.com/462467 did not update GN deps for new header.

BUG=645890,708965
TEST=none
==========

[Michael Achenbach, 2017-04-06 19:54:38]

Hmm, black magic...

[DaleCurtis, 2017-04-06 19:55:01]

cc: brettw since it's unclear to me why this change caught a heretofore uncaught
gn check  issue of the lacking WebRTC DEP from
https://codereview.chromium.org/2797303004

[commit-bot: I haz the power, 2017-04-06 20:01:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 20:01:12]

Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ilnik_chromium, 2017-04-06 20:02:46]

On 2017/04/06 19:51:05, DaleCurtis wrote:
> Hmm, doesn't repro locally, but error looks legit, so adding BUILD.gn DEP for
> video_codecs API.
> 
> +ilnik in case this is incorrect https://codereview.chromium.org/2797303004

LGTM. The problem is, that the old headers in webrtc didn't have any build
target in them. That's probably why it was passing all the checks. New, moved
headers now have a target for them. However, I forgot to check that that target
is actually used. Still can't understand, why the bots are failing now,

[DaleCurtis, 2017-04-06 20:04:09]

The CQ bit was checked by dalecurtis@chromium.org

[DaleCurtis, 2017-04-06 20:04:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org, ilnik@chromium.org, brucedawson@chromium.org,
yangguo@chromium.org, machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/2801123002/#ps40001
(title: "Actually fix DEPS...")

[commit-bot: I haz the power, 2017-04-06 20:05:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ilnik_chromium, 2017-04-06 20:07:17]

On 2017/04/06 20:02:46, ilnik1 wrote:
> On 2017/04/06 19:51:05, DaleCurtis wrote:
> > Hmm, doesn't repro locally, but error looks legit, so adding BUILD.gn DEP
for
> > video_codecs API.
> > 
> > +ilnik in case this is incorrect https://codereview.chromium.org/2797303004
> 
> LGTM. The problem is, that the old headers in webrtc didn't have any build
> target in them. That's probably why it was passing all the checks. New, moved
> headers now have a target for them. However, I forgot to check that that
target
> is actually used. Still can't understand, why the bots are failing now,

It's late here, and I can't think now. If you don't feel like dealing with this
staff, feel free to revert my commit. Let's hope it will help you. I will take a
look at it tomorrow.

[commit-bot: I haz the power, 2017-04-06 22:28:50]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491509049245700,
"parent_rev": "93dc65041b3f7e4fe97ffc91b8ab3954a7a6bf6a", "commit_rev":
"fd6c74121796da3012155a89c16ada1332736a06"}

[commit-bot: I haz the power, 2017-04-06 22:29:42]

Description was changed from

==========
Remove stale gn arg to avoid undeclared argument warning.

v8_enable_inspector was removed recently. Clean up remnants.

Also fixes a dependent gn check issue which blocked submission,
http://crrev.com/462467 did not update GN deps for new header.

BUG=645890,708965
TEST=none
==========

to

==========
Remove stale gn arg to avoid undeclared argument warning.

v8_enable_inspector was removed recently. Clean up remnants.

Also fixes a dependent gn check issue which blocked submission,
http://crrev.com/462467 did not update GN deps for new header.

BUG=645890,708965
TEST=none

Review-Url: https://codereview.chromium.org/2801123002
Cr-Commit-Position: refs/heads/master@{#462652}
Committed:
https://chromium.googlesource.com/chromium/src/+/fd6c74121796da3012155a89c16a...
==========

[commit-bot: I haz the power, 2017-04-06 22:29:44]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/fd6c74121796da3012155a89c16a...