Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Side by Side Diff: ios/BUILD.gn

Issue 2801123002: Remove stale gn arg to avoid undeclared argument warning. (Closed)
Patch Set: Actually fix DEPS... Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/test/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 assert(!is_component_build, "component build is unsupported on iOS") 5 assert(!is_component_build, "component build is unsupported on iOS")
6 6
7 import("//ios/features.gni") 7 import("//ios/features.gni")
8 8
9 declare_args() { 9 declare_args() {
10 # TODO(brettw) bug 684096: Remove these. These are to prevent unused 10 # TODO(brettw) bug 684096: Remove these. These are to prevent unused
11 # override warnings on iOS from the setting of the default_args in the 11 # override warnings on iOS from the setting of the default_args in the
12 # toplevel //.gn file. Since iOS doesn't compile V8, GN complains that 12 # toplevel //.gn file. Since iOS doesn't compile V8, GN complains that
13 # the overrides are never used. 13 # the overrides are never used.
14 v8_extra_library_files = [] 14 v8_extra_library_files = []
15 v8_experimental_extra_library_files = [] 15 v8_experimental_extra_library_files = []
16 v8_enable_inspector = true
17 v8_enable_gdbjit = false 16 v8_enable_gdbjit = false
18 v8_imminent_deprecation_warnings = false 17 v8_imminent_deprecation_warnings = false
19 } 18 }
20 19
21 # Prevent warnings for unused build args above. 20 # Prevent warnings for unused build args above.
22 assert(v8_extra_library_files != 0) 21 assert(v8_extra_library_files != 0)
23 assert(v8_experimental_extra_library_files != 0) 22 assert(v8_experimental_extra_library_files != 0)
24 assert(v8_enable_inspector)
25 assert(!v8_enable_gdbjit) 23 assert(!v8_enable_gdbjit)
26 assert(!v8_imminent_deprecation_warnings) 24 assert(!v8_imminent_deprecation_warnings)
27 25
28 # This list all targets that needs to be build as part of "gn_all" on iOS. 26 # This list all targets that needs to be build as part of "gn_all" on iOS.
29 # This list should generally only include executables, but since some code 27 # This list should generally only include executables, but since some code
30 # has not yet been upstreamed it will sometimes also include targets that 28 # has not yet been upstreamed it will sometimes also include targets that
31 # are not used upstream to ensure they are not broken inadvertently. 29 # are not used upstream to ensure they are not broken inadvertently.
32 group("all") { 30 group("all") {
33 testonly = true 31 testonly = true
34 if (is_cronet_build) { 32 if (is_cronet_build) {
(...skipping 21 matching lines...) Expand all
56 "//ios/clean/chrome/test:all_tests", 54 "//ios/clean/chrome/test:all_tests",
57 "//ios/net:all_tests", 55 "//ios/net:all_tests",
58 "//ios/showcase:all_tests", 56 "//ios/showcase:all_tests",
59 "//ios/testing:all_tests", 57 "//ios/testing:all_tests",
60 "//ios/web:all_tests", 58 "//ios/web:all_tests",
61 "//ios/web/shell/test:all_tests", 59 "//ios/web/shell/test:all_tests",
62 "//ios/web_view/shell/test:all_tests", 60 "//ios/web_view/shell/test:all_tests",
63 ] 61 ]
64 } 62 }
65 } 63 }
OLDNEW
« no previous file with comments | « content/test/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698