Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2801053004: Let floats to use all available size if opportunity is infinite (Closed)

Created:
3 years, 8 months ago by Gleb Lanbin
Modified:
3 years, 8 months ago
Reviewers:
ikilpatrick
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Let floats to use all available size if opportunity is infinite Because of the implementation specific of the layout opportunity iterator an empty opportunity can mean 2 things: - search for layout opportunities is exhausted. - opportunity has an infinite size. That's because CS is infinite. This patch fixes DCHECK crashes when we return an infinite opportunity. BUG=635619 Review-Url: https://codereview.chromium.org/2801053004 Cr-Commit-Position: refs/heads/master@{#462969} Committed: https://chromium.googlesource.com/chromium/src/+/958c1c976cd22ec4ed8e5695351ea3868b096961

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_floats_utils.cc View 1 chunk +12 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
Gleb Lanbin
3 years, 8 months ago (2017-04-07 00:02:46 UTC) #3
Gleb Lanbin
3 years, 8 months ago (2017-04-07 00:04:22 UTC) #4
ikilpatrick
lgtm
3 years, 8 months ago (2017-04-07 17:12:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801053004/20001
3 years, 8 months ago (2017-04-07 19:34:13 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 19:47:23 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/958c1c976cd22ec4ed8e5695351e...

Powered by Google App Engine
This is Rietveld 408576698