Let floats to use all available size if opportunity is infinite

third_party/WebKit/Source/core/layout/ng/ng_floats_utils.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/layout/ng/ng_floats_utils.h"
 
 #include "core/layout/ng/ng_box_fragment.h"
 
 namespace blink {
 namespace {
@@ skipping 109 matching lines @@
                               NGConstraintSpace* new_parent_space) {
   DCHECK(floating_object);
   DCHECK(floating_object->fragment) << "Fragment cannot be null here";
 
   // TODO(ikilpatrick): The writing mode switching here looks wrong.
   NGBoxFragment float_fragment(
       floating_object->writing_mode,
       toNGPhysicalBoxFragment(floating_object->fragment.get()));
 
   // Find a layout opportunity that will fit our float.
-  const NGLayoutOpportunity opportunity = FindLayoutOpportunityForFragment(
+  NGLayoutOpportunity opportunity = FindLayoutOpportunityForFragment(
       new_parent_space, float_fragment, floating_object);
-  DCHECK(!opportunity.IsEmpty()) << "Opportunity is empty but it shouldn't be";
+
+  // TODO(glebl): This should check for infinite opportunity instead.
+  if (opportunity.IsEmpty()) {
+    // Because of the implementation specific of the layout opportunity iterator
+    // an empty opportunity can mean 2 things:
+    // - search for layout opportunities is exhausted.
+    // - opportunity has an infinite size. That's because CS is infinite.
+    opportunity = NGLayoutOpportunity(
+        NGLogicalOffset(),
+        NGLogicalSize(float_fragment.InlineSize(), float_fragment.BlockSize()));
+  }
 
   // Calculate the float offset if needed.
   LayoutUnit float_offset;
   if (floating_object->exclusion_type == NGExclusion::kFloatRight) {
     LayoutUnit float_margin_box_inline_size =
         float_fragment.InlineSize() + floating_object->margins.InlineSum();
     float_offset = opportunity.size.inline_size - float_margin_box_inline_size;
   }
 
   // Add the float as an exclusion.
@@ skipping 20 matching lines @@
     floating_object->origin_offset.block_offset = origin_block_offset;
     floating_object->from_offset.block_offset = bfc_block_offset;
 
     NGLogicalOffset offset = PositionFloat(floating_object.get(), space);
     builder->AddFloatingObject(floating_object, offset);
   }
   builder->MutableUnpositionedFloats().clear();
 }
 
 }  // namespace blink