Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4692)

Unified Diff: chrome/browser/chromeos/chrome_browser_main_chromeos.cc

Issue 2801023004: chromeos: Fix chrome --mus startup crashes on device (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/exo/wm_helper_ash.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/chrome_browser_main_chromeos.cc
diff --git a/chrome/browser/chromeos/chrome_browser_main_chromeos.cc b/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
index 5702a4fb3e95be31ec811236540d675ac1032648..1ef51b2e7655598c888a15d86147f854b7ef739c 100644
--- a/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
+++ b/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
@@ -36,6 +36,7 @@
#include "chrome/browser/chromeos/app_mode/kiosk_app_manager.h"
#include "chrome/browser/chromeos/app_mode/kiosk_mode_idle_app_name_notification.h"
#include "chrome/browser/chromeos/arc/arc_service_launcher.h"
+#include "chrome/browser/chromeos/ash_config.h"
#include "chrome/browser/chromeos/boot_times_recorder.h"
#include "chrome/browser/chromeos/dbus/chrome_console_service_provider_delegate.h"
#include "chrome/browser/chromeos/dbus/chrome_display_power_service_provider_delegate.h"
@@ -215,9 +216,19 @@ class DBusServices {
public:
explicit DBusServices(const content::MainFunctionParams& parameters) {
// Under mash, some D-Bus clients are owned by other processes.
- DBusThreadManager::ProcessMask process_mask =
- ash_util::IsRunningInMash() ? DBusThreadManager::PROCESS_BROWSER
- : DBusThreadManager::PROCESS_ALL;
+ DBusThreadManager::ProcessMask process_mask;
+ switch (GetAshConfig()) {
+ case ash::Config::CLASSIC:
+ process_mask = DBusThreadManager::PROCESS_ALL;
+ break;
+ case ash::Config::MUS:
+ // TODO(jamescook|derat): We need another category for mushrome.
+ process_mask = DBusThreadManager::PROCESS_ALL;
+ break;
+ case ash::Config::MASH:
+ process_mask = DBusThreadManager::PROCESS_BROWSER;
+ break;
+ }
// Initialize DBusThreadManager for the browser. This must be done after
// the main message loop is started, as it uses the message loop.
@@ -234,19 +245,19 @@ class DBusServices {
service_providers.push_back(
base::MakeUnique<ProxyResolutionServiceProvider>(
base::MakeUnique<ChromeProxyResolutionServiceProviderDelegate>()));
- if (!ash_util::IsRunningInMash()) {
+ if (GetAshConfig() == ash::Config::CLASSIC) {
// TODO(crbug.com/629707): revisit this with mustash dbus work.
service_providers.push_back(base::MakeUnique<DisplayPowerServiceProvider>(
base::MakeUnique<ChromeDisplayPowerServiceProviderDelegate>()));
}
service_providers.push_back(base::MakeUnique<LivenessServiceProvider>());
service_providers.push_back(base::MakeUnique<ScreenLockServiceProvider>());
- if (ash_util::IsRunningInMash()) {
+ if (GetAshConfig() == ash::Config::CLASSIC) {
service_providers.push_back(base::MakeUnique<ConsoleServiceProvider>(
- base::MakeUnique<MusConsoleServiceProviderDelegate>()));
+ base::MakeUnique<ChromeConsoleServiceProviderDelegate>()));
} else {
service_providers.push_back(base::MakeUnique<ConsoleServiceProvider>(
- base::MakeUnique<ChromeConsoleServiceProviderDelegate>()));
+ base::MakeUnique<MusConsoleServiceProviderDelegate>()));
}
service_providers.push_back(base::MakeUnique<KioskInfoService>(
kLibCrosServiceInterface,
« no previous file with comments | « no previous file | components/exo/wm_helper_ash.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698