bindings: Skip undefined property descriptors when creating records.

bindings: Skip undefined property descriptors when creating records.

We were being too aggressive with our DCHECK(desc->IsObject()). The spec
says (and we even mention it in a comment) that a call to
Object.getOwnPropertyDescriptor can return undefined in addition to a proper
object descriptor.

We were only considering the latter case, and crashing on the DCHECK if we
ever received an undefined descriptor, which can happen when a Proxy is used
in JS.

This is also covered by external/wpt/fetch/api/headers/headers-record.html.

BUG=707365
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org

Review-Url: https://codereview.chromium.org/2801003005
Cr-Commit-Position: refs/heads/master@{#462850}
Committed: https://chromium.googlesource.com/chromium/src/+/9e1372a28311ec4b7fee0ae76eba7301069e7c6a

[Raphael Kubo da Costa (rakuco), 2017-04-07 12:06:49]

PTAL

[Raphael Kubo da Costa (rakuco), 2017-04-07 12:06:57]

The CQ bit was checked by raphael.kubo.da.costa@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 12:07:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuki, 2017-04-07 12:19:48]

LGTM. :)

[commit-bot: I haz the power, 2017-04-07 13:39:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 13:39:32]

Dry run: This issue passed the CQ dry run.

[Raphael Kubo da Costa (rakuco), 2017-04-07 13:40:00]

The CQ bit was checked by raphael.kubo.da.costa@intel.com

[commit-bot: I haz the power, 2017-04-07 13:40:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-04-07 13:59:48]

LGTM

[commit-bot: I haz the power, 2017-04-07 14:30:15]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491572400668240, "parent_rev":
"22fd5f0cf18a409dd72b96cb526a25a6cac88d24", "commit_rev":
"9e1372a28311ec4b7fee0ae76eba7301069e7c6a"}

[commit-bot: I haz the power, 2017-04-07 14:31:07]

Description was changed from

==========
bindings: Skip undefined property descriptors when creating records.

We were being too aggressive with our DCHECK(desc->IsObject()). The spec
says (and we even mention it in a comment) that a call to
Object.getOwnPropertyDescriptor can return undefined in addition to a proper
object descriptor.

We were only considering the latter case, and crashing on the DCHECK if we
ever received an undefined descriptor, which can happen when a Proxy is used
in JS.

This is also covered by external/wpt/fetch/api/headers/headers-record.html.

BUG=707365
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org
==========

to

==========
bindings: Skip undefined property descriptors when creating records.

We were being too aggressive with our DCHECK(desc->IsObject()). The spec
says (and we even mention it in a comment) that a call to
Object.getOwnPropertyDescriptor can return undefined in addition to a proper
object descriptor.

We were only considering the latter case, and crashing on the DCHECK if we
ever received an undefined descriptor, which can happen when a Proxy is used
in JS.

This is also covered by external/wpt/fetch/api/headers/headers-record.html.

BUG=707365
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org

Review-Url: https://codereview.chromium.org/2801003005
Cr-Commit-Position: refs/heads/master@{#462850}
Committed:
https://chromium.googlesource.com/chromium/src/+/9e1372a28311ec4b7fee0ae76eba...
==========

[commit-bot: I haz the power, 2017-04-07 14:31:08]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9e1372a28311ec4b7fee0ae76eba...