Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/NativeValueTraitsImpl.h

Issue 2801003005: bindings: Skip undefined property descriptors when creating records. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/bindings/record-type.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/NativeValueTraitsImpl.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/NativeValueTraitsImpl.h b/third_party/WebKit/Source/bindings/core/v8/NativeValueTraitsImpl.h
index 1713d4f5883928e0666bec081d44b41a0248a800..587075504827033dfa87483db6c913a79ac693e9 100644
--- a/third_party/WebKit/Source/bindings/core/v8/NativeValueTraitsImpl.h
+++ b/third_party/WebKit/Source/bindings/core/v8/NativeValueTraitsImpl.h
@@ -375,6 +375,8 @@ struct NativeValueTraits<IDLRecord<K, V>>
// GetOwnPropertyDescriptor is responsible for catching any exceptions
// and failures, and if we got to this point of the code we have a proper
// object that was not created by a user.
+ if (desc->IsUndefined())
+ continue;
DCHECK(desc->IsObject());
v8::Local<v8::Value> enumerable =
v8::Local<v8::Object>::Cast(desc)
« no previous file with comments | « third_party/WebKit/LayoutTests/bindings/record-type.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698