Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 2800923005: Pause close timer of notification while it's active (Closed)

Created:
3 years, 8 months ago by yoshiki
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Pause close timer of notification while it's active This patch makes notifications keeping visible while the focus is in notification. Previously, notification disappeared while user is typing direct reply. This patch solves this issue. BUG=708456 BUG=b/36801560 TEST=manually Review-Url: https://codereview.chromium.org/2788673004 Cr-Commit-Position: refs/heads/master@{#461637} (cherry picked from commit d9271fbbafb0fcc5e104d7e397cf3dbb9f9aeda1) Review-Url: https://codereview.chromium.org/2800923005 . Cr-Commit-Position: refs/branch-heads/3029@{#622} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/f81c8a2325bc0031153204b95ebc7e8cb860d6b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -3 lines) Patch
M ui/message_center/views/message_popup_collection.h View 2 chunks +9 lines, -0 lines 0 comments Download
M ui/message_center/views/message_popup_collection.cc View 4 chunks +23 lines, -3 lines 0 comments Download
M ui/message_center/views/toast_contents_view.h View 3 chunks +5 lines, -0 lines 0 comments Download
M ui/message_center/views/toast_contents_view.cc View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
yoshiki
3 years, 8 months ago (2017-04-07 07:56:33 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f81c8a2325bc0031153204b95ebc7e8cb860d6b4.

Powered by Google App Engine
This is Rietveld 408576698