Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2788673004: Pause close timer of notification while it's active (Closed)

Created:
3 years, 8 months ago by yoshiki
Modified:
3 years, 8 months ago
Reviewers:
yhanada
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Pause close timer of notification while it's active This patch makes notifications keeping visible while the focus is in notification. Previously, notification disappeared while user is typing direct reply. This patch solves this issue. BUG=b/36801560 TEST=manually

Patch Set 1 #

Patch Set 2 : . #

Total comments: 4

Patch Set 3 : Added comment for methods and property #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -3 lines) Patch
M ui/message_center/views/message_popup_collection.h View 1 2 2 chunks +9 lines, -0 lines 0 comments Download
M ui/message_center/views/message_popup_collection.cc View 1 4 chunks +23 lines, -3 lines 0 comments Download
M ui/message_center/views/toast_contents_view.h View 3 chunks +5 lines, -0 lines 0 comments Download
M ui/message_center/views/toast_contents_view.cc View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (17 generated)
yoshiki
Hanada-san, PTAL. Thanks.
3 years, 8 months ago (2017-04-04 04:16:21 UTC) #11
yhanada
https://codereview.chromium.org/2788673004/diff/20001/ui/message_center/views/message_popup_collection.cc File ui/message_center/views/message_popup_collection.cc (right): https://codereview.chromium.org/2788673004/diff/20001/ui/message_center/views/message_popup_collection.cc#newcode147 ui/message_center/views/message_popup_collection.cc:147: timer_pause_counter_++; I'm not familiar with Chromium C++ style, but ...
3 years, 8 months ago (2017-04-04 04:24:09 UTC) #12
yoshiki
PTAL again. https://codereview.chromium.org/2788673004/diff/20001/ui/message_center/views/message_popup_collection.cc File ui/message_center/views/message_popup_collection.cc (right): https://codereview.chromium.org/2788673004/diff/20001/ui/message_center/views/message_popup_collection.cc#newcode147 ui/message_center/views/message_popup_collection.cc:147: timer_pause_counter_++; On 2017/04/04 04:24:09, yhanada wrote: > ...
3 years, 8 months ago (2017-04-04 04:58:27 UTC) #15
yoshiki
PTAL again.
3 years, 8 months ago (2017-04-04 04:58:30 UTC) #16
yhanada
lgtm, thank you for adding the comment!
3 years, 8 months ago (2017-04-04 04:59:58 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2788673004/40001
3 years, 8 months ago (2017-04-04 05:27:15 UTC) #21
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 8 months ago (2017-04-04 05:36:54 UTC) #24
yoshiki
3 years, 8 months ago (2017-04-04 05:52:23 UTC) #25
It looks already committed. Let me close this manually.

Powered by Google App Engine
This is Rietveld 408576698