Pause close timer of notification while it's active

Pause close timer of notification while it's active

This patch makes notifications keeping visible while the focus is in notification. Previously, notification disappeared while user is typing direct reply. This patch solves this issue.

BUG=b/36801560
TEST=manually

[yoshiki, 2017-03-31 10:50:37]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 10:50:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 11:01:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 11:01:06]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yoshiki, 2017-03-31 12:08:51]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 12:09:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 12:55:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 12:55:14]

Dry run: This issue passed the CQ dry run.

[yoshiki, 2017-04-04 02:39:24]

Description was changed from

==========
wip


BUG=
==========

to

==========
Pause close timer of notification while it's active

This patch makes notifications keeping visible while the focus is in
notification. Previously, notification disappeared while user is typing direct
reply. This patch solves this issue.

BUG=b/36801560
TEST=manually
==========

[yoshiki, 2017-04-04 02:39:25]

yoshiki@chromium.org changed reviewers:
+ yhanada@chromium.org

[yoshiki, 2017-04-04 04:16:21]

Hanada-san, PTAL. Thanks.

[yhanada, 2017-04-04 04:24:09]

https://codereview.chromium.org/2788673004/diff/20001/ui/message_center/views...
File ui/message_center/views/message_popup_collection.cc (right):

https://codereview.chromium.org/2788673004/diff/20001/ui/message_center/views...
ui/message_center/views/message_popup_collection.cc:147: timer_pause_counter_++;
I'm not familiar with Chromium C++ style, but is it ok to use postfix operators?

https://codereview.chromium.org/2788673004/diff/20001/ui/message_center/views...
File ui/message_center/views/message_popup_collection.h (right):

https://codereview.chromium.org/2788673004/diff/20001/ui/message_center/views...
ui/message_center/views/message_popup_collection.h:171: int timer_pause_counter_
= 0;
It's great to add comment about what this variable stands for.

[yoshiki, 2017-04-04 04:34:51]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 04:35:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoshiki, 2017-04-04 04:58:27]

PTAL again.

https://codereview.chromium.org/2788673004/diff/20001/ui/message_center/views...
File ui/message_center/views/message_popup_collection.cc (right):

https://codereview.chromium.org/2788673004/diff/20001/ui/message_center/views...
ui/message_center/views/message_popup_collection.cc:147: timer_pause_counter_++;
On 2017/04/04 04:24:09, yhanada wrote:
> I'm not familiar with Chromium C++ style, but is it ok to use postfix
operators?

I think it's ok unless incrementing objects.

https://codereview.chromium.org/2788673004/diff/20001/ui/message_center/views...
File ui/message_center/views/message_popup_collection.h (right):

https://codereview.chromium.org/2788673004/diff/20001/ui/message_center/views...
ui/message_center/views/message_popup_collection.h:171: int timer_pause_counter_
= 0;
On 2017/04/04 04:24:09, yhanada wrote:
> It's great to add comment about what this variable stands for.

Done.

[yoshiki, 2017-04-04 04:58:30]

PTAL again.

[yhanada, 2017-04-04 04:59:58]

lgtm, thank you for adding the comment!

[commit-bot: I haz the power, 2017-04-04 05:25:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 05:25:57]

Dry run: This issue passed the CQ dry run.

[yoshiki, 2017-04-04 05:27:04]

The CQ bit was checked by yoshiki@chromium.org

[commit-bot: I haz the power, 2017-04-04 05:27:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 05:31:43]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491283624240570,
"parent_rev": "e50d7a2ae677c7a766c0a74385d367d757a4699e", "commit_rev":
"d9271fbbafb0fcc5e104d7e397cf3dbb9f9aeda1"}

[commit-bot: I haz the power, 2017-04-04 05:36:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 05:36:54]

Prior attempt to commit was detected, but we were not able to check whether the
issue was successfully committed. Please check Git history manually and re-check
CQ or close this issue as needed.

[yoshiki, 2017-04-04 05:52:23]

It looks already committed. Let me close this manually.