Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(115)

Issue 2800893002: Use ScopedTaskEnvironment instead of MessageLoop in content unit tests. (Closed)

Created:
1 year, 11 months ago by fdoray
Modified:
1 year, 11 months ago
CC:
avayvod+watch_chromium.org, chromium-reviews, cmumford, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org, emircan+watch+mediarecorder_chromium.org, emircan+watch+capturefromdom_chromium.org, feature-media-reviews_chromium.org, jam, jkarlin+watch_chromium.org, jsbell+idb_chromium.org, kinuko+fileapi, mcasas+mediarecorder_chromium.org, mcasas+capturefromelement_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-media_chromium.org, nhiroki, piman+watch_chromium.org, posciak+watch_chromium.org, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ScopedTaskEnvironment instead of MessageLoop in content unit tests. ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and base/task_scheduler/post_task.h within its scope. It should be instantiated in every unit test that uses either of these APIs (i.e. no test should instantiate a MessageLoop directly). Motivation for ScopedTaskEnvironment can be found in: https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3Pkk/edit BUG=708584 R=gab@chromium.org TBR=michaeln@chromium.org, aelias@chromium.org, yfriedman@chromium.org Review-Url: https://codereview.chromium.org/2800893002 Cr-Commit-Position: refs/heads/master@{#462528} Committed: https://chromium.googlesource.com/chromium/src/+/86573e43dc92125878dcafc820c5dce12876317e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -25 lines) Patch
M content/browser/android/url_request_content_job_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/appcache/appcache_quota_client_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/appcache/appcache_service_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/appcache/mock_appcache_storage_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/fileapi/copy_or_move_file_validator_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/fileapi/file_system_context_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/fileapi/file_system_operation_runner_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/fileapi/file_system_quota_client_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/fileapi/local_file_util_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/fileapi/recursive_operation_delegate_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/fileapi/sandbox_file_system_backend_delegate_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/fileapi/sandbox_file_system_backend_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/fileapi/transient_file_util_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/quota/mock_quota_manager_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/quota/quota_manager_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/quota/quota_temporary_storage_evictor_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/quota/usage_tracker_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/pepper/quota_reservation_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/child/indexed_db/webidbcursor_impl_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/gpu/queue_message_swap_promise_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/input/input_event_filter_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/media/android/stream_texture_wrapper_impl_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/media_capture_from_element/html_audio_element_capturer_source_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/renderer/media_recorder/audio_track_recorder_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (7 generated)
fdoray
1 year, 11 months ago (2017-04-05 19:43:42 UTC) #1
fdoray
gab@: PTAL The change will then be TBRed to the owner.
1 year, 11 months ago (2017-04-05 19:43:45 UTC) #3
aelias_OOO_until_Jul13
lgtm
1 year, 11 months ago (2017-04-05 20:04:43 UTC) #7
gab
lgtm
1 year, 11 months ago (2017-04-05 20:55:23 UTC) #8
michaeln
r/s lgtm
1 year, 11 months ago (2017-04-05 23:57:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2800893002/1
1 year, 11 months ago (2017-04-06 15:28:12 UTC) #11
commit-bot: I haz the power
1 year, 11 months ago (2017-04-06 17:27:33 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/86573e43dc92125878dcafc820c5...

Powered by Google App Engine
This is Rietveld 408576698