Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Side by Side Diff: content/browser/fileapi/sandbox_file_system_backend_delegate_unittest.cc

Issue 2800893002: Use ScopedTaskEnvironment instead of MessageLoop in content unit tests. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "storage/browser/fileapi/sandbox_file_system_backend_delegate.h" 5 #include "storage/browser/fileapi/sandbox_file_system_backend_delegate.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/files/file_util.h" 9 #include "base/files/file_util.h"
10 #include "base/files/scoped_temp_dir.h" 10 #include "base/files/scoped_temp_dir.h"
11 #include "base/test/scoped_task_environment.h"
11 #include "base/threading/thread_task_runner_handle.h" 12 #include "base/threading/thread_task_runner_handle.h"
12 #include "content/public/test/test_file_system_options.h" 13 #include "content/public/test/test_file_system_options.h"
13 #include "storage/browser/fileapi/file_system_url.h" 14 #include "storage/browser/fileapi/file_system_url.h"
14 #include "testing/gtest/include/gtest/gtest.h" 15 #include "testing/gtest/include/gtest/gtest.h"
15 #include "url/gurl.h" 16 #include "url/gurl.h"
16 17
17 using storage::FileSystemURL; 18 using storage::FileSystemURL;
18 19
19 namespace content { 20 namespace content {
20 21
(...skipping 17 matching lines...) Expand all
38 NULL /* quota_manager_proxy */, 39 NULL /* quota_manager_proxy */,
39 base::ThreadTaskRunnerHandle::Get().get(), data_dir_.GetPath(), 40 base::ThreadTaskRunnerHandle::Get().get(), data_dir_.GetPath(),
40 NULL /* special_storage_policy */, CreateAllowFileAccessOptions())); 41 NULL /* special_storage_policy */, CreateAllowFileAccessOptions()));
41 } 42 }
42 43
43 bool IsAccessValid(const FileSystemURL& url) const { 44 bool IsAccessValid(const FileSystemURL& url) const {
44 return delegate_->IsAccessValid(url); 45 return delegate_->IsAccessValid(url);
45 } 46 }
46 47
47 base::ScopedTempDir data_dir_; 48 base::ScopedTempDir data_dir_;
48 base::MessageLoop message_loop_; 49 base::test::ScopedTaskEnvironment scoped_task_environment_;
49 std::unique_ptr<storage::SandboxFileSystemBackendDelegate> delegate_; 50 std::unique_ptr<storage::SandboxFileSystemBackendDelegate> delegate_;
50 }; 51 };
51 52
52 TEST_F(SandboxFileSystemBackendDelegateTest, IsAccessValid) { 53 TEST_F(SandboxFileSystemBackendDelegateTest, IsAccessValid) {
53 // Normal case. 54 // Normal case.
54 EXPECT_TRUE(IsAccessValid(CreateFileSystemURL("a"))); 55 EXPECT_TRUE(IsAccessValid(CreateFileSystemURL("a")));
55 56
56 // Access to a path with parent references ('..') should be disallowed. 57 // Access to a path with parent references ('..') should be disallowed.
57 EXPECT_FALSE(IsAccessValid(CreateFileSystemURL("a/../b"))); 58 EXPECT_FALSE(IsAccessValid(CreateFileSystemURL("a/../b")));
58 59
(...skipping 19 matching lines...) Expand all
78 EXPECT_TRUE(IsAccessValid(CreateFileSystemURL(" ."))); 79 EXPECT_TRUE(IsAccessValid(CreateFileSystemURL(" .")));
79 EXPECT_TRUE(IsAccessValid(CreateFileSystemURL(". "))); 80 EXPECT_TRUE(IsAccessValid(CreateFileSystemURL(". ")));
80 EXPECT_TRUE(IsAccessValid(CreateFileSystemURL("b."))); 81 EXPECT_TRUE(IsAccessValid(CreateFileSystemURL("b.")));
81 EXPECT_TRUE(IsAccessValid(CreateFileSystemURL(".b"))); 82 EXPECT_TRUE(IsAccessValid(CreateFileSystemURL(".b")));
82 83
83 // A path that looks like a drive letter. 84 // A path that looks like a drive letter.
84 EXPECT_TRUE(IsAccessValid(CreateFileSystemURL("c:"))); 85 EXPECT_TRUE(IsAccessValid(CreateFileSystemURL("c:")));
85 } 86 }
86 87
87 } // namespace content 88 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698