Update both end time and end reason when we don't have an end time.

Update both end time and end reason when we don't have an end time.

In the PageLoadTracker destructor, if we encounter a load without
an end time, we use the current time as the end time.

However, this causes a DCHECK in GetPageLoadExtraInfo to fire shortly
after, since the end time and end reason are out of sync.

This change makes sure that both end time and end reason stay in sync
when this case is encountered.

This also re-enables a disabled test that was failing due to the
GetPageLoadExtraInfo DCHECK.

BUG=651844
Review-Url: https://codereview.chromium.org/2800873002
Cr-Commit-Position: refs/heads/master@{#462317}
Committed: https://chromium.googlesource.com/chromium/src/+/6b17878ebc18e3f4df888b42ec74e5d3b4b0be94

[Bryan McQuade, 2017-04-05 18:57:51]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 18:58:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bryan McQuade, 2017-04-05 18:58:48]

bmcquade@chromium.org changed reviewers:
+ csharrison@chromium.org

[Bryan McQuade, 2017-04-05 18:58:54]

PTAL, thanks!

[Charlie Harrison, 2017-04-05 19:07:59]

lgtm

[commit-bot: I haz the power, 2017-04-05 20:18:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 20:18:12]

Dry run: This issue passed the CQ dry run.

[Bryan McQuade, 2017-04-05 20:22:15]

bmcquade@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[Bryan McQuade, 2017-04-05 20:23:16]

Description was changed from

==========
Update both end time and end reason when we don't have an end time.

In the PageLoadTracker destructor, if we encounter a load without
an end time, we use the current time as the end time.

However, this causes a DCHECK in GetPageLoadExtraInfo to fire shortly
after, since the end time and end reason are out of sync.

This change makes sure that both end time and end reason stay in sync
when this case is encountered.

BUG=651844
==========

to

==========
Update both end time and end reason when we don't have an end time.

In the PageLoadTracker destructor, if we encounter a load without
an end time, we use the current time as the end time.

However, this causes a DCHECK in GetPageLoadExtraInfo to fire shortly
after, since the end time and end reason are out of sync.

This change makes sure that both end time and end reason stay in sync
when this case is encountered.

This also re-enables a disabled test that was failing due to the
GetPageLoadExtraInfo DCHECK.

BUG=651844
==========

[Bryan McQuade, 2017-04-05 20:23:35]

rdevlin, PTAL for extensions browsertest fix, thanks!

[Devlin, 2017-04-06 01:21:14]

lgtm!

[Bryan McQuade, 2017-04-06 01:40:20]

The CQ bit was checked by bmcquade@chromium.org

[commit-bot: I haz the power, 2017-04-06 01:40:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 01:47:21]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491442820040510, "parent_rev":
"0e96f32be23cec35909ce8193d91c14ef1b72b13", "commit_rev":
"6b17878ebc18e3f4df888b42ec74e5d3b4b0be94"}

[commit-bot: I haz the power, 2017-04-06 01:48:15]

Description was changed from

==========
Update both end time and end reason when we don't have an end time.

In the PageLoadTracker destructor, if we encounter a load without
an end time, we use the current time as the end time.

However, this causes a DCHECK in GetPageLoadExtraInfo to fire shortly
after, since the end time and end reason are out of sync.

This change makes sure that both end time and end reason stay in sync
when this case is encountered.

This also re-enables a disabled test that was failing due to the
GetPageLoadExtraInfo DCHECK.

BUG=651844
==========

to

==========
Update both end time and end reason when we don't have an end time.

In the PageLoadTracker destructor, if we encounter a load without
an end time, we use the current time as the end time.

However, this causes a DCHECK in GetPageLoadExtraInfo to fire shortly
after, since the end time and end reason are out of sync.

This change makes sure that both end time and end reason stay in sync
when this case is encountered.

This also re-enables a disabled test that was failing due to the
GetPageLoadExtraInfo DCHECK.

BUG=651844

Review-Url: https://codereview.chromium.org/2800873002
Cr-Commit-Position: refs/heads/master@{#462317}
Committed:
https://chromium.googlesource.com/chromium/src/+/6b17878ebc18e3f4df888b42ec74...
==========

[commit-bot: I haz the power, 2017-04-06 01:48:16]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6b17878ebc18e3f4df888b42ec74...