Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: chrome/browser/page_load_metrics/page_load_tracker.cc

Issue 2800873002: Update both end time and end reason when we don't have an end time. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/isolated_app_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/page_load_tracker.cc
diff --git a/chrome/browser/page_load_metrics/page_load_tracker.cc b/chrome/browser/page_load_metrics/page_load_tracker.cc
index 25c2883503484333a617d9ccfedb9182b6eb5e1a..10e75f5f333bc65ed07c4c56204a637b16e7f032 100644
--- a/chrome/browser/page_load_metrics/page_load_tracker.cc
+++ b/chrome/browser/page_load_metrics/page_load_tracker.cc
@@ -322,8 +322,12 @@ PageLoadTracker::~PageLoadTracker() {
return;
if (page_end_time_.is_null()) {
+ // page_end_time_ can be unset in some cases, such as when a navigation is
+ // aborted by a navigation that started before it. In these cases, set the
+ // end time to the current time.
RecordInternalError(ERR_NO_PAGE_LOAD_END_TIME);
- page_end_time_ = base::TimeTicks::Now();
+ NotifyPageEnd(END_OTHER, UserInitiatedInfo::NotUserInitiated(),
+ base::TimeTicks::Now(), true);
}
if (!did_commit_) {
« no previous file with comments | « chrome/browser/extensions/isolated_app_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698