PPC/S390: Fix to use correct instr to test bitmask

PPC/S390: Fix to use correct instr to test bitmask

R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
BUG=
LOG=N

Review-Url: https://codereview.chromium.org/2800813002
Cr-Commit-Position: refs/heads/master@{#44618}
Committed: https://chromium.googlesource.com/v8/v8/+/79bce3d655128e98c9f405764f699af3f5ad8c7d

[john.yan, 2017-04-11 17:29:55]

lgtm

[john.yan, 2017-04-11 17:30:41]

https://codereview.chromium.org/2800813002/diff/1/src/builtins/s390/builtins-...
File src/builtins/s390/builtins-s390.cc (right):

https://codereview.chromium.org/2800813002/diff/1/src/builtins/s390/builtins-...
src/builtins/s390/builtins-s390.cc:674:
Operand(static_cast<int>(SuspendFlags::kAsyncGeneratorAwait)));
use tmll?

[JaideepBajwa, 2017-04-11 22:45:01]

https://codereview.chromium.org/2800813002/diff/1/src/builtins/s390/builtins-...
File src/builtins/s390/builtins-s390.cc (right):

https://codereview.chromium.org/2800813002/diff/1/src/builtins/s390/builtins-...
src/builtins/s390/builtins-s390.cc:674:
Operand(static_cast<int>(SuspendFlags::kAsyncGeneratorAwait)));
On 2017/04/11 17:30:41, john.yan wrote:
> use tmll?
I tried changing to
  __ tmll(r5, Operand(static_cast<int>(SuspendFlags::kAsyncGeneratorAwait)));
  __ bne(&async_await);
But that is causing some failures, am I missing anything?

[john.yan, 2017-04-12 14:12:46]

On 2017/04/11 22:45:01, JaideepBajwa wrote:
>
https://codereview.chromium.org/2800813002/diff/1/src/builtins/s390/builtins-...
> File src/builtins/s390/builtins-s390.cc (right):
> 
>
https://codereview.chromium.org/2800813002/diff/1/src/builtins/s390/builtins-...
> src/builtins/s390/builtins-s390.cc:674:
> Operand(static_cast<int>(SuspendFlags::kAsyncGeneratorAwait)));
> On 2017/04/11 17:30:41, john.yan wrote:
> > use tmll?
> I tried changing to
>   __ tmll(r5, Operand(static_cast<int>(SuspendFlags::kAsyncGeneratorAwait)));
>   __ bne(&async_await);
> But that is causing some failures, am I missing anything?

nvm, because r5 is used later.

[john.yan, 2017-04-12 14:12:56]

On 2017/04/12 14:12:46, john.yan wrote:
> On 2017/04/11 22:45:01, JaideepBajwa wrote:
> >
>
https://codereview.chromium.org/2800813002/diff/1/src/builtins/s390/builtins-...
> > File src/builtins/s390/builtins-s390.cc (right):
> > 
> >
>
https://codereview.chromium.org/2800813002/diff/1/src/builtins/s390/builtins-...
> > src/builtins/s390/builtins-s390.cc:674:
> > Operand(static_cast<int>(SuspendFlags::kAsyncGeneratorAwait)));
> > On 2017/04/11 17:30:41, john.yan wrote:
> > > use tmll?
> > I tried changing to
> >   __ tmll(r5,
Operand(static_cast<int>(SuspendFlags::kAsyncGeneratorAwait)));
> >   __ bne(&async_await);
> > But that is causing some failures, am I missing anything?
> 
> nvm, because r5 is used later.

lgtm

[JaideepBajwa, 2017-04-12 14:16:07]

On 2017/04/12 14:12:56, john.yan wrote:
> On 2017/04/12 14:12:46, john.yan wrote:
> > On 2017/04/11 22:45:01, JaideepBajwa wrote:
> > >
> >
>
https://codereview.chromium.org/2800813002/diff/1/src/builtins/s390/builtins-...
> > > File src/builtins/s390/builtins-s390.cc (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2800813002/diff/1/src/builtins/s390/builtins-...
> > > src/builtins/s390/builtins-s390.cc:674:
> > > Operand(static_cast<int>(SuspendFlags::kAsyncGeneratorAwait)));
> > > On 2017/04/11 17:30:41, john.yan wrote:
> > > > use tmll?
> > > I tried changing to
> > >   __ tmll(r5,
> Operand(static_cast<int>(SuspendFlags::kAsyncGeneratorAwait)));
> > >   __ bne(&async_await);
> > > But that is causing some failures, am I missing anything?
> > 
> > nvm, because r5 is used later.
> 
> lgtm

Thanks!

[JaideepBajwa, 2017-04-12 14:16:10]

The CQ bit was checked by bjaideep@ca.ibm.com

[commit-bot: I haz the power, 2017-04-12 14:16:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 14:45:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492006570809660,
"parent_rev": "53475efcaacc96b03db9e999619b32c1378151ce", "commit_rev":
"79bce3d655128e98c9f405764f699af3f5ad8c7d"}

[commit-bot: I haz the power, 2017-04-12 14:45:46]

Description was changed from

==========
PPC/S390: Fix to use correct instr to test bitmask

R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
BUG=
LOG=N
==========

to

==========
PPC/S390: Fix to use correct instr to test bitmask

R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
BUG=
LOG=N

Review-Url: https://codereview.chromium.org/2800813002
Cr-Commit-Position: refs/heads/master@{#44618}
Committed:
https://chromium.googlesource.com/v8/v8/+/79bce3d655128e98c9f405764f699af3f5a...
==========

[commit-bot: I haz the power, 2017-04-12 14:45:46]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/79bce3d655128e98c9f405764f699af3f5a...