PPC/S390: Fix to use correct instr to test bitmask

src/builtins/s390/builtins-s390.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #if V8_TARGET_ARCH_S390
 
 #include "src/codegen.h"
 #include "src/debug/debug.h"
 #include "src/deoptimizer.h"
 #include "src/full-codegen/full-codegen.h"
@@ skipping 652 matching lines @@
   //  -- r4 : the resume mode (tagged)
   //  -- r5 : the SuspendFlags of the earlier suspend call (tagged)
   //  -- lr : return address
   // -----------------------------------
   __ SmiUntag(r5);
   __ AssertGeneratorObject(r3, r5);
 
   // Store input value into generator object.
   Label async_await, done_store_input;
 
-  __ And(r5, r5, Operand(static_cast<int>(SuspendFlags::kAsyncGeneratorAwait)));
+  __ AndP(r5, r5,
+          Operand(static_cast<int>(SuspendFlags::kAsyncGeneratorAwait)));

[john.yan, 2017/04/11 17:30:41]

use tmll?

[JaideepBajwa, 2017/04/11 22:45:01]

I tried changing to
  __ tmll(r5, Operand(static_cast<int>(SuspendFlags::kAsyncGeneratorAwait)));
  __ bne(&async_await);
But that is causing some failures, am I missing anything?

   __ CmpP(r5, Operand(static_cast<int>(SuspendFlags::kAsyncGeneratorAwait)));
   __ beq(&async_await);
 
   __ StoreP(r2, FieldMemOperand(r3, JSGeneratorObject::kInputOrDebugPosOffset),
             r0);
   __ RecordWriteField(r3, JSGeneratorObject::kInputOrDebugPosOffset, r2, r5,
                       kLRHasNotBeenSaved, kDontSaveFPRegs);
   __ b(&done_store_input);
 
   __ bind(&async_await);
@@ skipping 2408 matching lines @@
   // Now jump to the instructions of the returned code object.
   __ Jump(ip);
 }
 
 #undef __
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_TARGET_ARCH_S390