Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1160)

Issue 2800733004: [DevTools] Account for synthetic events in deepElementFromPoint() (Closed)

Created:
3 years, 8 months ago by dgozman
Modified:
3 years, 8 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, extensions-reviews_chromium.org, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Account for synthetic events in deepElementFromPoint() Synthetic events have zero coordinates and return incorrect element from deepElementFromPoint() call. This leads to GlassPane handling the click incorrectly. BUG=707130 Review-Url: https://codereview.chromium.org/2800733004 Cr-Commit-Position: refs/heads/master@{#462318} Committed: https://chromium.googlesource.com/chromium/src/+/345ac542f1ee7737574e70ec508a5ecd13cd4006

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/dom_extension/DOMExtension.js View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
dgozman
Take a look please.
3 years, 8 months ago (2017-04-05 21:31:15 UTC) #2
lushnikov
lgtm
3 years, 8 months ago (2017-04-06 00:54:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2800733004/1
3 years, 8 months ago (2017-04-06 00:54:44 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 01:51:43 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/345ac542f1ee7737574e70ec508a...

Powered by Google App Engine
This is Rietveld 408576698