Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js

Issue 2800733004: [DevTools] Account for synthetic events in deepElementFromPoint() (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/dom_extension/DOMExtension.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js b/third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js
index 831020febb1ea1fd6b2f977786e205be74dfe925..82664a70d951cd7c9bf2b675bf6702bcb3542ffe 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js
@@ -143,7 +143,8 @@ UI.GlassPane = class {
_onMouseDown(event) {
if (!this._onClickOutsideCallback)
return;
- if (this.contentElement.isSelfOrAncestor(/** @type {?Node} */ (event.deepElementFromPoint())))
+ var node = event.deepElementFromPoint();
+ if (!node || this.contentElement.isSelfOrAncestor(node))
return;
this._onClickOutsideCallback.call(null, event);
}
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/dom_extension/DOMExtension.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698