Sync confirmation: change "Settings" link to checkbox

Sync confirmation: change "Settings" link to checkbox

This is so all users must confirm sign in via "OK, GOT IT"
instead of clicking "Settings" link (which closes the dialog
without either of the "UNDO" or "OK, GOT IT" buttons being
clicked).

R=rogerta@chromium.org
BUG=709113
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2800683008
Cr-Commit-Position: refs/heads/master@{#462675}
Committed: https://chromium.googlesource.com/chromium/src/+/cafbdba2f02dddaa020d228b591051692bcae535

[Dan Beam, 2017-04-06 17:40:00]

Description was changed from

==========
Sync confirmation: change "Settings" link to checkbox

This is so all users must confirm sign in via "OK, GOT IT"
instead of clicking "Settings" link (which closes the dialog
without either of the "UNDO" or "OK, GOT IT" buttons being
clicked).

R=tommycli@chromium.org
BUG=none
==========

to

==========
Sync confirmation: change "Settings" link to checkbox

This is so all users must confirm sign in via "OK, GOT IT"
instead of clicking "Settings" link (which closes the dialog
without either of the "UNDO" or "OK, GOT IT" buttons being
clicked).

R=tommycli@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-04-06 18:00:51]

Description was changed from

==========
Sync confirmation: change "Settings" link to checkbox

This is so all users must confirm sign in via "OK, GOT IT"
instead of clicking "Settings" link (which closes the dialog
without either of the "UNDO" or "OK, GOT IT" buttons being
clicked).

R=tommycli@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Sync confirmation: change "Settings" link to checkbox

This is so all users must confirm sign in via "OK, GOT IT"
instead of clicking "Settings" link (which closes the dialog
without either of the "UNDO" or "OK, GOT IT" buttons being
clicked).

R=tommycli@chromium.org
BUG=709113 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-04-06 18:39:35]

Patchset #1 (id:1) has been deleted

[Dan Beam, 2017-04-06 18:41:37]

dbeam@chromium.org changed reviewers:
+ rogerta@chromium.org
- tommycli@chromium.org

[Dan Beam, 2017-04-06 18:41:49]

Description was changed from

==========
Sync confirmation: change "Settings" link to checkbox

This is so all users must confirm sign in via "OK, GOT IT"
instead of clicking "Settings" link (which closes the dialog
without either of the "UNDO" or "OK, GOT IT" buttons being
clicked).

R=tommycli@chromium.org
BUG=709113 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Sync confirmation: change "Settings" link to checkbox

This is so all users must confirm sign in via "OK, GOT IT"
instead of clicking "Settings" link (which closes the dialog
without either of the "UNDO" or "OK, GOT IT" buttons being
clicked).

R=rpgerta@chromium.org
BUG=709113 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-04-06 18:42:10]

Description was changed from

==========
Sync confirmation: change "Settings" link to checkbox

This is so all users must confirm sign in via "OK, GOT IT"
instead of clicking "Settings" link (which closes the dialog
without either of the "UNDO" or "OK, GOT IT" buttons being
clicked).

R=rpgerta@chromium.org
BUG=709113 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Sync confirmation: change "Settings" link to checkbox

This is so all users must confirm sign in via "OK, GOT IT"
instead of clicking "Settings" link (which closes the dialog
without either of the "UNDO" or "OK, GOT IT" buttons being
clicked).

R=rogerta@chromium.org
BUG=709113 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-04-06 18:42:17]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[Dan Beam, 2017-04-06 18:42:41]

screenshots here, btw
https://bugs.chromium.org/p/chromium/issues/detail?id=709113#c2

[commit-bot: I haz the power, 2017-04-06 18:43:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Roger Tawa OOO till Jul 10th, 2017-04-06 18:52:10]

lgtm

[commit-bot: I haz the power, 2017-04-06 19:51:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 19:51:41]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2017-04-06 23:02:11]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2017-04-06 23:03:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 23:22:31]

CQ is committing da patch.

Bot data: {"patchset_id": 10007, "attempt_start_ts": 1491519731760060,
"parent_rev": "12399c275d9261a7cb37816faffd1b7e35fbbd6b", "commit_rev":
"cafbdba2f02dddaa020d228b591051692bcae535"}

[commit-bot: I haz the power, 2017-04-06 23:23:23]

Description was changed from

==========
Sync confirmation: change "Settings" link to checkbox

This is so all users must confirm sign in via "OK, GOT IT"
instead of clicking "Settings" link (which closes the dialog
without either of the "UNDO" or "OK, GOT IT" buttons being
clicked).

R=rogerta@chromium.org
BUG=709113 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Sync confirmation: change "Settings" link to checkbox

This is so all users must confirm sign in via "OK, GOT IT"
instead of clicking "Settings" link (which closes the dialog
without either of the "UNDO" or "OK, GOT IT" buttons being
clicked).

R=rogerta@chromium.org
BUG=709113 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2800683008
Cr-Commit-Position: refs/heads/master@{#462675}
Committed:
https://chromium.googlesource.com/chromium/src/+/cafbdba2f02dddaa020d228b5910...
==========

[commit-bot: I haz the power, 2017-04-06 23:23:24]

Committed patchset #1 (id:10007) as
https://chromium.googlesource.com/chromium/src/+/cafbdba2f02dddaa020d228b5910...