Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2391)

Unified Diff: chrome/browser/resources/signin/sync_confirmation/sync_confirmation.html

Issue 2800683008: Sync confirmation: change "Settings" link to checkbox (Closed)
Patch Set: tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/signin/sync_confirmation/sync_confirmation.html
diff --git a/chrome/browser/resources/signin/sync_confirmation/sync_confirmation.html b/chrome/browser/resources/signin/sync_confirmation/sync_confirmation.html
index ca7b87ef1da42034157cfc8f2dd41969a61148f6..582a25a16dd6060c576e78a9d3edf97dbda73192 100644
--- a/chrome/browser/resources/signin/sync_confirmation/sync_confirmation.html
+++ b/chrome/browser/resources/signin/sync_confirmation/sync_confirmation.html
@@ -1,9 +1,11 @@
<!doctype html>
-<html i18n-values="dir:textdirection;lang:language">
+<html dir="$i18n{textdirection}" lang="$i18n{language}">
<head>
<meta charset="utf-8">
<link rel="import" href="chrome://resources/html/polymer.html">
+ <link rel="import" href="chrome://resources/cr_elements/shared_vars_css.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
+ <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-checkbox.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/color.html">
<link rel="import" href="signin_shared_css.html">
<link rel="stylesheet" href="chrome://resources/css/text_defaults_md.css">
@@ -15,6 +17,15 @@
-webkit-margin-start: 0;
}
</if>
+ /* TODO(dbeam): de-duplicate this style with MD Settings. */
+ paper-checkbox {
+ --paper-checkbox-checked-color: var(--google-blue-500);
+ --paper-checkbox-label-color: inherit;
+ --paper-checkbox-label-spacing: 18px;
+ --paper-checkbox-size: 16px;
+ --paper-checkbox-unchecked-color: var(--paper-grey-600);
+ -webkit-margin-start: 2px;
+ }
</style>
</head>
<body>
@@ -56,8 +67,9 @@
<div id="chrome-logo" class="logo"></div>
<div>
<div class="title">$i18n{syncConfirmationChromeSyncTitle}</div>
- <div class="body text"
- i18n-values=".innerHTML:syncConfirmationChromeSyncBody"></div>
+ <div class="body text">
+ $i18nRaw{syncConfirmationChromeSyncBody}
+ </div>
</div>
</div>
<div class="message-container">
@@ -76,8 +88,10 @@
</div>
</div>
<div class="message-container">
- <div class="body"
- i18n-values=".innerHTML:syncConfirmationSyncSettingsLinkBody">
+ <div class="body">
+ <paper-checkbox id="configure-before-signing-in">
+ $i18n{syncConfirmationSyncSettingsLabel}
+ </paper-checkbox>
</div>
</div>
</div>
@@ -99,5 +113,4 @@
<script src="chrome://resources/js/util.js"></script>
<script src="sync_confirmation.js"></script>
<script src="chrome://sync-confirmation/strings.js"></script>
- <script src="chrome://resources/js/i18n_template.js"></script>
</html>
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/resources/signin/sync_confirmation/sync_confirmation.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698