Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 2800523004: Restrict navigator.getInstalledRelatedApps() to top-level frames (Closed)

Created:
3 years, 8 months ago by Timothy Loh
Modified:
3 years, 8 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, blink-reviews, haraken, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Restrict navigator.getInstalledRelatedApps() to top-level frames As getInstalledRelatedApps is a privacy-sensitive API, restricting it to top-level frames should help reduce potential undesired usage while not adversely affecting intended usage (e.g. ads in iframes won't be able to use this). BUG=707620 Review-Url: https://codereview.chromium.org/2800523004 Cr-Commit-Position: refs/heads/master@{#462798} Committed: https://chromium.googlesource.com/chromium/src/+/ae333e41aeaa7a3646b067bc2da0673990be32b4

Patch Set 1 #

Patch Set 2 : update error (top-level frames -> top-level browing contexts) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/installedapp/getinstalledrelatedapps-iframe.html View 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (15 generated)
Timothy Loh
3 years, 8 months ago (2017-04-05 05:28:15 UTC) #4
Matt Giuca
lgtm, thanks!
3 years, 8 months ago (2017-04-07 04:37:09 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2800523004/20001
3 years, 8 months ago (2017-04-07 05:04:56 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 06:47:41 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ae333e41aeaa7a3646b067bc2da0...

Powered by Google App Engine
This is Rietveld 408576698