Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(214)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: third_party/WebKit/LayoutTests/installedapp/getinstalledrelatedapps-iframe.html
Issue
2800523004
:
Restrict navigator.getInstalledRelatedApps() to top-level frames (Closed)
Patch Set: update error (top-level frames -> top-level browing contexts)
Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
third_party/WebKit/LayoutTests/installedapp/getinstalledrelatedapps-iframe.html
third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp
View unified diff
|
Download patch
« no previous file with comments
|
« no previous file
|
third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<!DOCTYPE html>
2
<script src="../resources/testharness.js"></script>
3
<script src="../resources/testharnessreport.js"></script>
4
<iframe srcdoc="
5
<!DOCTYPE html>
6
<script>
7
window.top.promise_test(function() {
8
var expectedError = 'InvalidStateError';
9
var promise = navigator.getInstalledRelatedApps();
10
return window.top.promise_rejects(this, expectedError, promise);
11
}, 'getInstalledRelatedApps() should error when called in an iframe.');
12
</script>
13
"></iframe>
OLD
NEW
« no previous file with comments
|
« no previous file
|
third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp »
('j') |
no next file with comments »
Issue 2800523004: Restrict navigator.getInstalledRelatedApps() to top-level frames (Closed)
Created 3 years, 8 months ago by Timothy Loh
Modified 3 years, 8 months ago
Reviewers: Matt Giuca
Base URL:
Comments: 0
This is Rietveld
408576698