Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: ios/web_view/internal/web_view_web_client.mm

Issue 2800433002: Remove CWVDelegate. (Closed)
Patch Set: Respond to comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web_view/internal/web_view_web_client.h ('k') | ios/web_view/internal/web_view_web_main_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web_view/internal/web_view_web_client.mm
diff --git a/ios/web_view/internal/web_view_web_client.mm b/ios/web_view/internal/web_view_web_client.mm
index 56aed9bfd7c5c71e84f0f0eb13f8246ffa7f82b1..a9c60a05d0ff75b889784b9d4d94aec7c0e5086e 100644
--- a/ios/web_view/internal/web_view_web_client.mm
+++ b/ios/web_view/internal/web_view_web_client.mm
@@ -4,12 +4,10 @@
#import "ios/web_view/internal/web_view_web_client.h"
-#include "base/strings/sys_string_conversions.h"
#include "ios/web/public/user_agent.h"
#include "ios/web_view/internal/web_view_browser_state.h"
#import "ios/web_view/internal/web_view_early_page_script_provider.h"
#import "ios/web_view/internal/web_view_web_main_parts.h"
-#import "ios/web_view/public/cwv_delegate.h"
#if !defined(__has_feature) || !__has_feature(objc_arc)
#error "This file requires ARC support."
@@ -17,13 +15,13 @@
namespace ios_web_view {
-WebViewWebClient::WebViewWebClient(id<CWVDelegate> delegate)
- : delegate_(delegate), web_main_parts_(nullptr) {}
+WebViewWebClient::WebViewWebClient(const std::string& user_agent_product)
+ : user_agent_product_(user_agent_product), web_main_parts_(nullptr) {}
WebViewWebClient::~WebViewWebClient() = default;
web::WebMainParts* WebViewWebClient::CreateWebMainParts() {
- web_main_parts_ = new WebViewWebMainParts(delegate_);
+ web_main_parts_ = new WebViewWebMainParts();
return web_main_parts_;
}
@@ -36,7 +34,7 @@ WebViewBrowserState* WebViewWebClient::off_the_record_browser_state() const {
}
std::string WebViewWebClient::GetProduct() const {
- return base::SysNSStringToUTF8([delegate_ partialUserAgent]);
+ return user_agent_product_;
}
std::string WebViewWebClient::GetUserAgent(web::UserAgentType type) const {
« no previous file with comments | « ios/web_view/internal/web_view_web_client.h ('k') | ios/web_view/internal/web_view_web_main_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698