Fix duplicated records of Signin_Impression_FromSettings action

Fix duplicated records of Signin_Impression_FromSettings action

This CL changes conditions for recording Signin_Impression_FromSettings user
action.
Before: user action is recorded on every call to update() if user
isn't signed in and policy allows sign in.
After: subsequent calls to update() don't result in new records if preference
was already in "not signed in" state.

BUG=697572
Review-Url: https://codereview.chromium.org/2800343003
Cr-Commit-Position: refs/heads/master@{#463645}
Committed: https://chromium.googlesource.com/chromium/src/+/1a22fcd0dd4dcd32fa2e60eb7eb7552aff88bc10

[bsazonov, 2017-04-10 12:37:41]

The CQ bit was checked by bsazonov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 12:37:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 13:13:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 13:13:35]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2017-04-10 14:05:01]

bauerb@chromium.org changed reviewers:
+ bauerb@chromium.org

[Bernhard Bauer, 2017-04-10 14:05:02]

https://codereview.chromium.org/2800343003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/SignInPreference.java
(right):

https://codereview.chromium.org/2800343003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/SignInPreference.java:41:
private Boolean mIsSignedIn;
Can you make this a non-Nullable boolean and initialize it to true? It's a bit
weird to have three states where two of them are equivalent.

[bsazonov, 2017-04-11 11:20:24]

Bernhard, please take a look. What do you think about current implementation?

https://codereview.chromium.org/2800343003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/SignInPreference.java
(right):

https://codereview.chromium.org/2800343003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/SignInPreference.java:41:
private Boolean mIsSignedIn;
On 2017/04/10 14:05:01, Bernhard Bauer wrote:
> Can you make this a non-Nullable boolean and initialize it to true? It's a bit
> weird to have three states where two of them are equivalent.

Hm, I think that initializing "mSignedIn" it to true can be a bit surprising to
someone who's not familiar with this code. If you want to use non-Nullable
boolean here, we should probably tailor it for this specific task (see next
patch).

[Bernhard Bauer, 2017-04-11 15:28:01]

Thanks! The new patch set LGTM.

[bsazonov, 2017-04-11 15:28:49]

The CQ bit was checked by bsazonov@chromium.org

[commit-bot: I haz the power, 2017-04-11 15:29:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 16:12:29]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491924529855310,
"parent_rev": "05beffe3c7d2325ee0d3593eface36f063a403e9", "commit_rev":
"1a22fcd0dd4dcd32fa2e60eb7eb7552aff88bc10"}

[commit-bot: I haz the power, 2017-04-11 16:13:22]

Description was changed from

==========
Fix duplicated records of Signin_Impression_FromSettings action

This CL changes conditions for recording Signin_Impression_FromSettings user
action.
Before: user action is recorded on every call to update() if user
isn't signed in and policy allows sign in.
After: subsequent calls to update() don't result in new records if preference
was already in "not signed in" state.

BUG=697572
==========

to

==========
Fix duplicated records of Signin_Impression_FromSettings action

This CL changes conditions for recording Signin_Impression_FromSettings user
action.
Before: user action is recorded on every call to update() if user
isn't signed in and policy allows sign in.
After: subsequent calls to update() don't result in new records if preference
was already in "not signed in" state.

BUG=697572

Review-Url: https://codereview.chromium.org/2800343003
Cr-Commit-Position: refs/heads/master@{#463645}
Committed:
https://chromium.googlesource.com/chromium/src/+/1a22fcd0dd4dcd32fa2e60eb7eb7...
==========

[commit-bot: I haz the power, 2017-04-11 16:13:23]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1a22fcd0dd4dcd32fa2e60eb7eb7...