Fix duplicated records of Signin_Impression_FromSettings action

chrome/android/java/src/org/chromium/chrome/browser/preferences/SignInPreference.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.preferences;
 
 import android.content.Context;
 import android.content.res.Resources;
 import android.graphics.Bitmap;
 import android.graphics.drawable.BitmapDrawable;
@@ skipping 20 matching lines @@
 
 /**
  * A preference that displays "Sign in to Chrome" when the user is not sign in, and displays
  * the user's name, email, profile image and sync error icon if necessary when the user is signed
  * in.
  */
 public class SignInPreference extends Preference
         implements SignInAllowedObserver, ProfileDownloader.Observer,
                    AndroidSyncSettings.AndroidSyncSettingsObserver, SyncStateChangedListener {
     private boolean mViewEnabled;
+    private boolean mShowingPromo;
 
     /**
      * Constructor for inflating from XML.
      */
     public SignInPreference(Context context, AttributeSet attrs) {
         super(context, attrs);
         update();
     }
 
     /**
@@ skipping 26 matching lines @@
         }
     }
 
     /**
      * Updates the title, summary, and image based on the current sign-in state.
      */
     private void update() {
         String accountName = ChromeSigninController.get().getSignedInAccountName();
         if (SigninManager.get(getContext()).isSigninDisabledByPolicy()) {
             setupSigninDisabled();
+            mShowingPromo = false;
         } else if (accountName == null) {
             setupNotSignedIn();
+
+            if (!mShowingPromo) {
+                // This user action should be recorded when message with sign-in prompt is shown
+                RecordUserAction.record("Signin_Impression_FromSettings");
+            }
+            mShowingPromo = true;
         } else {
             setupSignedIn(accountName);
+            mShowingPromo = false;
         }
 
         setOnPreferenceClickListener(new OnPreferenceClickListener() {
             @Override
             public boolean onPreferenceClick(Preference preference) {
                 return AccountSigninActivity.startIfAllowed(
                         getContext(), SigninAccessPoint.SETTINGS);
             }
         });
-
-        if (accountName == null && SigninManager.get(getContext()).isSignInAllowed()) {
-            RecordUserAction.record("Signin_Impression_FromSettings");
-        }
     }
 
     private void setupSigninDisabled() {
         setTitle(R.string.sign_in_to_chrome);
         setSummary(R.string.sign_in_to_chrome_summary);
         setFragment(null);
         setIcon(ManagedPreferencesUtils.getManagedByEnterpriseIconId());
         setWidgetLayoutResource(0);
         setViewEnabled(false);
     }
@@ skipping 71 matching lines @@
         AccountManagementFragment.updateUserNamePictureCache(accountId, fullName, bitmap);
         update();
     }
 
     // AndroidSyncSettings.AndroidSyncSettingsObserver
     @Override
     public void androidSyncSettingsChanged() {
         update();
     }
 }