Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2800243002: Replace remaining ASSERTs and ASSERT_NOT_REACHED in core/layout/ (Closed)

Created:
3 years, 8 months ago by mrunal
Modified:
3 years, 8 months ago
Reviewers:
eae
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace remaining ASSERTs and ASSERT_NOT_REACHED in core/layout/ It looks like these were added recently in last 2-3 weeks. BUG=697685 Review-Url: https://codereview.chromium.org/2800243002 Cr-Commit-Position: refs/heads/master@{#464582} Committed: https://chromium.googlesource.com/chromium/src/+/942077b08a652ac7fdb0f51f02c1a6fd44fd4cc8

Patch Set 1 #

Patch Set 2 : Rebase with latest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm_test.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_space_utils.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (14 generated)
mrunal
eae, PTAL.
3 years, 8 months ago (2017-04-10 21:27:41 UTC) #7
eae
On 2017/04/10 21:27:41, mrunal wrote: > eae, PTAL. LGTM
3 years, 8 months ago (2017-04-11 11:09:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2800243002/1
3 years, 8 months ago (2017-04-11 11:10:02 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/407800)
3 years, 8 months ago (2017-04-11 11:12:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2800243002/20001
3 years, 8 months ago (2017-04-13 00:48:53 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/429715)
3 years, 8 months ago (2017-04-13 02:34:17 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2800243002/20001
3 years, 8 months ago (2017-04-13 21:54:25 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 22:45:40 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/942077b08a652ac7fdb0f51f02c1...

Powered by Google App Engine
This is Rietveld 408576698