Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm_test.cc

Issue 2800243002: Replace remaining ASSERTs and ASSERT_NOT_REACHED in core/layout/ (Closed)
Patch Set: Rebase with latest Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/ng/ng_space_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm_test.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm_test.cc b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm_test.cc
index 119147aa2470ea6afb2b867c51975877135e0ee7..4976df7870346cb829d2b27dbfa9b58f400837dc 100644
--- a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm_test.cc
+++ b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm_test.cc
@@ -131,7 +131,7 @@ TEST_F(NGInlineLayoutAlgorithmTest, TextFloatsAroundFloatsBefore) {
LayoutText* layout_text =
ToLayoutText(GetLayoutObjectByElementId("text")->SlowFirstChild());
- ASSERT(layout_text->HasTextBoxes());
+ DCHECK(layout_text->HasTextBoxes());
ASSERT_EQ(4UL, text_fragments.size());
@@ -181,7 +181,7 @@ TEST_F(NGInlineLayoutAlgorithmTest, TextFloatsAroundInlineFloatThatFitsOnLine) {
)HTML");
LayoutText* layout_text =
ToLayoutText(GetLayoutObjectByElementId("text")->SlowFirstChild());
- ASSERT(layout_text->HasTextBoxes());
+ DCHECK(layout_text->HasTextBoxes());
InlineTextBox* inline_text_box1 = layout_text->FirstTextBox();
// 30 == narrow-float's width.
@@ -219,7 +219,7 @@ TEST_F(NGInlineLayoutAlgorithmTest,
)HTML");
LayoutText* layout_text =
ToLayoutText(GetLayoutObjectByElementId("text")->SlowFirstChild());
- ASSERT(layout_text->HasTextBoxes());
+ DCHECK(layout_text->HasTextBoxes());
InlineTextBox* inline_text_box1 = layout_text->FirstTextBox();
EXPECT_EQ(LayoutUnit(), inline_text_box1->X());
@@ -292,7 +292,7 @@ TEST_F(NGInlineLayoutAlgorithmTest, PositionFloatsWithMargins) {
)HTML");
LayoutText* layout_text =
ToLayoutText(GetLayoutObjectByElementId("text")->SlowFirstChild());
- ASSERT(layout_text->HasTextBoxes());
+ DCHECK(layout_text->HasTextBoxes());
InlineTextBox* inline_text_box1 = layout_text->FirstTextBox();
// 45 = sum of left's inline margins: 40 + left's width: 5
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/ng/ng_space_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698