|
Revert 269414 "Changes to deletion/ownership of nodes in the cli..."
> Changes to deletion/ownership of nodes in the client lib.
>
> Nodes are now owned by the view manager. Constructors/destructors moved to private/protected. The ViewManager now maintains a map of id->node.
> Adds an observer method for destruction. Clients will need to implement this to invalidate their pointer (perhaps I should invent a node smart ptr).
> Adds lib tests for node removal, destruction, and connection destruction (when a connection is destroyed, all nodes it created should be destroyed).
> Adds a client notification from the service to notify other clients of node destruction & some tests.
>
> R=sky@chromium.org
> http://crbug.com/365012
>
> Review URL: https://codereview.chromium.org/274733004
TBR=ben@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269421
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+106 lines, -327 lines) |
Patch |
 |
M |
trunk/src/mojo/examples/sample_view_manager_app/sample_view_manager_app.cc
|
View
|
|
2 chunks |
+7 lines, -6 lines |
0 comments
|
Download
|
 |
M |
trunk/src/mojo/services/public/cpp/view_manager/lib/view_manager.cc
|
View
|
|
2 chunks |
+1 line, -15 lines |
0 comments
|
Download
|
 |
M |
trunk/src/mojo/services/public/cpp/view_manager/lib/view_manager_private.h
|
View
|
|
1 chunk |
+1 line, -4 lines |
0 comments
|
Download
|
 |
M |
trunk/src/mojo/services/public/cpp/view_manager/lib/view_manager_private.cc
|
View
|
|
1 chunk |
+2 lines, -8 lines |
0 comments
|
Download
|
 |
M |
trunk/src/mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.h
|
View
|
|
4 chunks |
+0 lines, -6 lines |
0 comments
|
Download
|
 |
M |
trunk/src/mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc
|
View
|
|
7 chunks |
+10 lines, -30 lines |
0 comments
|
Download
|
 |
M |
trunk/src/mojo/services/public/cpp/view_manager/lib/view_tree_node.cc
|
View
|
|
2 chunks |
+27 lines, -42 lines |
0 comments
|
Download
|
 |
M |
trunk/src/mojo/services/public/cpp/view_manager/lib/view_tree_node_private.h
|
View
|
|
2 chunks |
+0 lines, -8 lines |
0 comments
|
Download
|
 |
M |
trunk/src/mojo/services/public/cpp/view_manager/lib/view_tree_node_private.cc
|
View
|
|
1 chunk |
+0 lines, -5 lines |
0 comments
|
Download
|
 |
M |
trunk/src/mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc
|
View
|
|
9 chunks |
+13 lines, -106 lines |
0 comments
|
Download
|
 |
M |
trunk/src/mojo/services/public/cpp/view_manager/tests/view_tree_node_unittest.cc
|
View
|
|
4 chunks |
+34 lines, -36 lines |
0 comments
|
Download
|
 |
M |
trunk/src/mojo/services/public/cpp/view_manager/view_manager.h
|
View
|
|
2 chunks |
+2 lines, -9 lines |
0 comments
|
Download
|
 |
M |
trunk/src/mojo/services/public/cpp/view_manager/view_tree_node.h
|
View
|
|
2 chunks |
+7 lines, -16 lines |
0 comments
|
Download
|
 |
M |
trunk/src/mojo/services/public/cpp/view_manager/view_tree_node_observer.h
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
M |
trunk/src/mojo/services/public/interfaces/view_manager/view_manager.mojom
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
M |
trunk/src/mojo/services/view_manager/root_node_manager.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
trunk/src/mojo/services/view_manager/root_node_manager.cc
|
View
|
|
1 chunk |
+0 lines, -10 lines |
0 comments
|
Download
|
 |
M |
trunk/src/mojo/services/view_manager/view_manager_connection.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
trunk/src/mojo/services/view_manager/view_manager_connection.cc
|
View
|
|
2 chunks |
+0 lines, -6 lines |
0 comments
|
Download
|
 |
M |
trunk/src/mojo/services/view_manager/view_manager_connection_unittest.cc
|
View
|
|
3 chunks |
+2 lines, -12 lines |
0 comments
|
Download
|
Total messages: 2 (0 generated)
|