Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 274733004: Deletion/ownership (Closed)

Created:
6 years, 7 months ago by Ben Goodger (Google)
Modified:
6 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Changes to deletion/ownership of nodes in the client lib. Nodes are now owned by the view manager. Constructors/destructors moved to private/protected. The ViewManager now maintains a map of id->node. Adds an observer method for destruction. Clients will need to implement this to invalidate their pointer (perhaps I should invent a node smart ptr). Adds lib tests for node removal, destruction, and connection destruction (when a connection is destroyed, all nodes it created should be destroyed). Adds a client notification from the service to notify other clients of node destruction & some tests. R=sky@chromium.org http://crbug.com/365012 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269414 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269426

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : #

Patch Set 5 : . #

Patch Set 6 : . #

Total comments: 2

Patch Set 7 : . #

Patch Set 8 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+327 lines, -106 lines) Patch
M mojo/examples/sample_view_manager_app/sample_view_manager_app.cc View 1 2 3 2 chunks +6 lines, -7 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager.cc View 1 2 3 4 5 2 chunks +15 lines, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_private.h View 1 2 3 4 1 chunk +4 lines, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_private.cc View 1 2 3 4 1 chunk +8 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.h View 1 2 3 4 5 4 chunks +6 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc View 1 2 3 4 5 7 chunks +30 lines, -10 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_tree_node.cc View 1 2 3 4 5 2 chunks +42 lines, -27 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_tree_node_private.h View 2 chunks +8 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_tree_node_private.cc View 1 2 3 4 5 6 7 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc View 1 2 3 4 5 6 9 chunks +106 lines, -13 lines 0 comments Download
M mojo/services/public/cpp/view_manager/tests/view_tree_node_unittest.cc View 1 4 chunks +36 lines, -34 lines 0 comments Download
M mojo/services/public/cpp/view_manager/view_manager.h View 1 2 3 4 2 chunks +9 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/view_tree_node.h View 1 2 3 4 5 6 7 2 chunks +16 lines, -7 lines 0 comments Download
M mojo/services/public/cpp/view_manager/view_tree_node_observer.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/services/public/interfaces/view_manager/view_manager.mojom View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/services/view_manager/root_node_manager.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/view_manager/root_node_manager.cc View 1 2 3 4 5 6 7 1 chunk +10 lines, -0 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection.cc View 1 2 3 4 5 6 7 2 chunks +6 lines, -0 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection_unittest.cc View 1 2 3 3 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ben Goodger (Google)
6 years, 7 months ago (2014-05-08 17:46:29 UTC) #1
sky
LGTM https://codereview.chromium.org/274733004/diff/100001/mojo/services/public/cpp/view_manager/lib/view_tree_node_private.cc File mojo/services/public/cpp/view_manager/lib/view_tree_node_private.cc (right): https://codereview.chromium.org/274733004/diff/100001/mojo/services/public/cpp/view_manager/lib/view_tree_node_private.cc#newcode23 mojo/services/public/cpp/view_manager/lib/view_tree_node_private.cc:23: nit: only one newline. https://codereview.chromium.org/274733004/diff/100001/mojo/services/public/cpp/view_manager/view_tree_node.h File mojo/services/public/cpp/view_manager/view_tree_node.h (right): ...
6 years, 7 months ago (2014-05-08 18:18:38 UTC) #2
Ben Goodger (Google)
The CQ bit was checked by ben@chromium.org
6 years, 7 months ago (2014-05-09 03:40:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/274733004/120001
6 years, 7 months ago (2014-05-09 03:46:37 UTC) #4
Ben Goodger (Google)
Committed patchset #7 manually as r269414 (presubmit successful).
6 years, 7 months ago (2014-05-09 21:32:56 UTC) #5
Ben Goodger (Google)
6 years, 7 months ago (2014-05-09 22:01:09 UTC) #6
Message was sent while issue was closed. 
Committed patchset #8 manually as r269426 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698